Bug 199813

Summary: Hop to main thread for release logging in RealtimeIncomingAudioSource
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, eric.carlson, jer.noble, krollin, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

youenn fablet
Reported 2019-07-15 16:20:49 PDT
Hop to main thread for release logging in RealtimeIncomingAudioSource
Attachments
patch (1.77 KB, patch)
2019-07-15 16:28 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
patch (2.04 KB, patch)
2019-07-15 16:46 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-07-15 16:23:17 PDT
<rdar://problem/53127693>
youenn fablet
Comment 2 2019-07-15 16:28:19 PDT
Created attachment 374163 [details] patch
Chris Dumez
Comment 3 2019-07-15 16:32:02 PDT
Comment on attachment 374163 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=374163&action=review > Source/WebCore/ChangeLog:3 > + Hop to main thread for release logging in RealtimeIncomingAudioSource Could you please explain why in the change loge? Isn't it safe to call RELEASE_LOG() from another thread?
youenn fablet
Comment 4 2019-07-15 16:46:34 PDT
Created attachment 374166 [details] patch
youenn fablet
Comment 5 2019-07-15 16:49:46 PDT
(In reply to Chris Dumez from comment #3) > Comment on attachment 374163 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=374163&action=review > > > Source/WebCore/ChangeLog:3 > > + Hop to main thread for release logging in RealtimeIncomingAudioSource > > Could you please explain why in the change loge? Isn't it safe to call > RELEASE_LOG() from another thread? It is not thread safe, see Logger::log in Logger.h. I updated the change log.
WebKit Commit Bot
Comment 6 2019-07-16 08:09:47 PDT
Comment on attachment 374166 [details] patch Clearing flags on attachment: 374166 Committed r247480: <https://trac.webkit.org/changeset/247480>
WebKit Commit Bot
Comment 7 2019-07-16 08:09:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.