Bug 199812

Summary:

Speed up StorageManager::getValues()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, commit-queue, ews-watchlist, ggaren, sihui_liu, simon.fraser, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

199892

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none
Patch	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none
Patch	none

Chris Dumez

Reported 2019-07-15 16:00:43 PDT

Speed up StorageManager::getValues().

Attachments
Patch (31.85 KB, patch) 2019-07-15 16:10 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.99 MB, application/zip) 2019-07-15 18:19 PDT, EWS Watchlist	no flags	Details
Patch (39.70 KB, patch) 2019-07-15 18:56 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (39.40 KB, patch) 2019-07-15 20:10 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.83 MB, application/zip) 2019-07-15 23:48 PDT, EWS Watchlist	no flags	Details
Patch (39.55 KB, patch) 2019-07-16 09:31 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (39.55 KB, patch) 2019-07-16 10:42 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-07-15 16:10:12 PDT

Created attachment 374161 [details] Patch

EWS Watchlist

Comment 2 2019-07-15 18:19:47 PDT

Comment on attachment 374161 [details] Patch Attachment 374161 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12746353 New failing tests: storage/domstorage/localstorage/private-browsing-affects-storage.html

EWS Watchlist

Comment 3 2019-07-15 18:19:50 PDT

Created attachment 374176 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

Chris Dumez

Comment 4 2019-07-15 18:56:56 PDT

Created attachment 374177 [details] Patch

Chris Dumez

Comment 5 2019-07-15 20:10:11 PDT

Created attachment 374187 [details] Patch

EWS Watchlist

Comment 6 2019-07-15 23:48:26 PDT

Comment on attachment 374187 [details] Patch Attachment 374187 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12748248 New failing tests: storage/domstorage/localstorage/private-browsing-affects-storage.html

EWS Watchlist

Comment 7 2019-07-15 23:48:27 PDT

Created attachment 374196 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

Chris Dumez

Comment 8 2019-07-16 09:31:52 PDT

Created attachment 374212 [details] Patch

Radar WebKit Bug Importer

Comment 9 2019-07-16 09:34:47 PDT

<rdar://problem/53156441>

Simon Fraser (smfr)

Comment 10 2019-07-16 10:41:19 PDT

Comment on attachment 374212 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374212&action=review > Source/WebKit/ChangeLog:11 > + thread hoping (IPC thread -> Main thread -> StorageManagerThread -> Main Thread) hopping

Chris Dumez

Comment 11 2019-07-16 10:42:50 PDT

Created attachment 374216 [details] Patch

Chris Dumez

Comment 12 2019-07-16 10:43:09 PDT

(In reply to Simon Fraser (smfr) from comment #10) > Comment on attachment 374212 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=374212&action=review > > > Source/WebKit/ChangeLog:11 > > + thread hoping (IPC thread -> Main thread -> StorageManagerThread -> Main Thread) > > hopping Darn, I keep making this mistake :D Thanks.

Geoffrey Garen

Comment 13 2019-07-16 10:44:18 PDT

r=me Can you add a comment about what you used to measure performance? Might be good to check that into PerformanceTests, even if it's manual.

Chris Dumez

Comment 14 2019-07-16 10:45:45 PDT

(In reply to Geoffrey Garen from comment #13) > r=me > > Can you add a comment about what you used to measure performance? Might be > good to check that into PerformanceTests, even if it's manual. I am using the following test page to measure performance: https://jsbin.com/zivayiviza/edit?html,output

Chris Dumez

Comment 15 2019-07-16 10:50:07 PDT

(In reply to Chris Dumez from comment #14) > (In reply to Geoffrey Garen from comment #13) > > r=me > > > > Can you add a comment about what you used to measure performance? Might be > > good to check that into PerformanceTests, even if it's manual. > > I am using the following test page to measure performance: > https://jsbin.com/zivayiviza/edit?html,output Namely, in MobileSafari: 1. Open https://jsbin.com/zivayiviza/edit?html,output 2. Click "Fill Local Storage" button 3. Once the "Done" alert shows, close it and exit MobileSafari 4. Open https://jsbin.com/zivayiviza/edit?html,output again 5. Focus the field Focusing the field at step 5 is very slow (~500ms) on my iPhone, which is what I am working to improve.

WebKit Commit Bot

Comment 16 2019-07-16 11:25:42 PDT

Comment on attachment 374216 [details] Patch Clearing flags on attachment: 374216 Committed r247486: <https://trac.webkit.org/changeset/247486>

WebKit Commit Bot

Comment 17 2019-07-16 11:25:44 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.