Bug 199782

Summary:

Streamline PODIntervalTree code and remove ValueToString

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebCore Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, annulen, benjamin, calvaris, cdumez, cmarcelo, commit-queue, dbates, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kangil.han, kondapallykalyan, pdr, philipj, rniwa, ryuan.choi, sergio

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

199452

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews107 for mac-highsierra-wk2	none
Archive of layout-test-results from ews117 for mac-highsierra	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Archive of layout-test-results from ews215 for win-future	none
Patch	none
Patch	none
Patch	andersca: review+, andersca: commit-queue+

Darin Adler

Reported 2019-07-13 18:19:15 PDT

Streamline PODIntervalTree code and remove ValueToString

Attachments
Patch (74.92 KB, patch) 2019-07-14 11:34 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.53 MB, application/zip) 2019-07-14 12:52 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (3.10 MB, application/zip) 2019-07-14 13:00 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-highsierra (3.13 MB, application/zip) 2019-07-14 13:41 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.72 MB, application/zip) 2019-07-14 13:46 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews215 for win-future (13.56 MB, application/zip) 2019-07-14 14:10 PDT, EWS Watchlist	no flags	Details
Patch (74.57 KB, patch) 2019-12-06 09:27 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (77.22 KB, patch) 2019-12-07 09:12 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (77.93 KB, patch) 2019-12-07 11:40 PST, Darin Adler	andersca: review+ andersca: commit-queue+	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2019-07-14 11:34:28 PDT Comment hidden (obsolete)

Created attachment 374087 [details] Patch

EWS Watchlist

Comment 2 2019-07-14 12:52:11 PDT Comment hidden (obsolete)

Comment on attachment 374087 [details] Patch Attachment 374087 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12738418 New failing tests: fast/multicol/simple-line-layout-widows-when-switching-over-to-normal-line-layout.html fast/multicol/pagination/LeftToRight-tb-hittest.html

EWS Watchlist

Comment 3 2019-07-14 12:52:12 PDT Comment hidden (obsolete)

Created attachment 374088 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 4 2019-07-14 13:00:11 PDT Comment hidden (obsolete)

Comment on attachment 374087 [details] Patch Attachment 374087 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12738426 New failing tests: fast/multicol/simple-line-layout-widows-when-switching-over-to-normal-line-layout.html fast/multicol/pagination/LeftToRight-tb-hittest.html

EWS Watchlist

Comment 5 2019-07-14 13:00:13 PDT Comment hidden (obsolete)

Created attachment 374089 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 6 2019-07-14 13:41:40 PDT Comment hidden (obsolete)

Comment on attachment 374087 [details] Patch Attachment 374087 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12738475 New failing tests: fast/multicol/simple-line-layout-widows-when-switching-over-to-normal-line-layout.html fast/multicol/pagination/LeftToRight-tb-hittest.html

EWS Watchlist

Comment 7 2019-07-14 13:41:42 PDT Comment hidden (obsolete)

Created attachment 374091 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 8 2019-07-14 13:46:03 PDT Comment hidden (obsolete)

Comment on attachment 374087 [details] Patch Attachment 374087 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12738479 New failing tests: fast/multicol/simple-line-layout-widows-when-switching-over-to-normal-line-layout.html

EWS Watchlist

Comment 9 2019-07-14 13:46:04 PDT Comment hidden (obsolete)

Created attachment 374092 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

EWS Watchlist

Comment 10 2019-07-14 14:10:39 PDT Comment hidden (obsolete)

Comment on attachment 374087 [details] Patch Attachment 374087 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12738529 New failing tests: fast/multicol/simple-line-layout-widows-when-switching-over-to-normal-line-layout.html fast/multicol/pagination/LeftToRight-tb-hittest.html

EWS Watchlist

Comment 11 2019-07-14 14:10:41 PDT Comment hidden (obsolete)

Created attachment 374093 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Darin Adler

Comment 12 2019-12-06 09:27:08 PST Comment hidden (obsolete)

Created attachment 385022 [details] Patch

Darin Adler

Comment 13 2019-12-07 09:12:44 PST Comment hidden (obsolete)

Created attachment 385099 [details] Patch

Darin Adler

Comment 14 2019-12-07 11:40:12 PST

Created attachment 385104 [details] Patch

Darin Adler

Comment 15 2019-12-08 11:57:12 PST

OK, everything seems to be working perfectly now and all the bubbles on EWS are green, so I'd like to find someone to review.

Anders Carlsson

Comment 16 2019-12-09 08:32:07 PST

Comment on attachment 385104 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385104&action=review > Source/WebCore/platform/PODRedBlackTree.h:104 > + insertNode(new Node(T { data })); Would be nice if insertNode took a unique_ptr - seeing "new" in modern C++ code always makes me uneasy.

Darin Adler

Comment 17 2019-12-09 09:01:53 PST

Comment on attachment 385104 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385104&action=review >> Source/WebCore/platform/PODRedBlackTree.h:104 >> + insertNode(new Node(T { data })); > > Would be nice if insertNode took a unique_ptr - seeing "new" in modern C++ code always makes me uneasy. I’ll try that out in a follow-up. (As you know, often my challenge is when to *stop* tweaking and refactoring.)

Darin Adler

Comment 18 2019-12-09 09:13:33 PST

Committed r253290

Note You need to log in before you can comment on or make changes to this bug.