Bug 199765

Summary: Increase JSValue cage size on iOS and reduce the max slide
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Keith Miller
Reported 2019-07-12 16:02:22 PDT
Increase JSValue cage size on iOS and reduce the max slide
Attachments
Patch (1.76 KB, patch)
2019-07-12 16:09 PDT, Keith Miller 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2019-07-12 16:09:59 PDT
Created attachment 374048 [details] Patch
Keith Miller
Comment 2 2019-07-12 16:11:05 PDT
rdar://problem/52589569
Saam Barati
Comment 3 2019-07-12 16:21:29 PDT
Comment on attachment 374048 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374048&action=review > Source/bmalloc/bmalloc/Gigacage.h:71 > constexpr size_t primitiveGigacageSize = 2 * bmalloc::Sizes::GB; > -constexpr size_t jsValueGigacageSize = 1 * bmalloc::Sizes::GB; > +constexpr size_t jsValueGigacageSize = 2 * bmalloc::Sizes::GB; should we bump to 4gb/4gb?
Saam Barati
Comment 4 2019-07-12 16:21:57 PDT
Comment on attachment 374048 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374048&action=review > Source/bmalloc/ChangeLog:12 > + might be nice for posterity to state that cage size is now 36gb and we ask for a 38gb allocation
Keith Miller
Comment 5 2019-07-12 17:22:32 PDT
Comment on attachment 374048 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374048&action=review >> Source/bmalloc/ChangeLog:12 >> + > > might be nice for posterity to state that cage size is now 36gb and we ask for a 38gb allocation Done. >> Source/bmalloc/bmalloc/Gigacage.h:71 >> +constexpr size_t jsValueGigacageSize = 2 * bmalloc::Sizes::GB; > > should we bump to 4gb/4gb? I'm not sure that's necessary. If we still have a problem we can consider it later.
Keith Miller
Comment 6 2019-07-12 17:23:16 PDT
Committed r247409: <https://trac.webkit.org/changeset/247409>
Note You need to log in before you can comment on or make changes to this bug.