Bug 199754

Summary: Regression(macOS Catalina): Cannot quick look html documents in Mail
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, bfulgham, commit-queue, ggaren, mitz, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202012
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2019-07-12 13:11:25 PDT 
Cannot quick look html documents in Mail due to sandboxing errors.
Comment 1 Chris Dumez 2019-07-12 13:11:41 PDT 
<rdar://problem/51304961>
Comment 2 Chris Dumez 2019-07-12 13:14:22 PDT 
Created attachment 374029 [details]
Patch
Comment 3 Geoffrey Garen 2019-07-12 13:15:56 PDT 
Comment on attachment 374029 [details]
Patch

Can we test this with an API test?
Comment 4 Chris Dumez 2019-07-12 13:20:57 PDT 
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 374029 [details]
> Patch
> 
> Can we test this with an API test?

No, as far as I know, we cannot API test sandboxing since TestWebKitAPI is not sandboxed.
Comment 5 Chris Dumez 2019-07-12 13:51:43 PDT 
Comment on attachment 374029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374029&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:1061
>      // FIXME: universal file read access should be set if the sandbox extension is successfully created: rdar://problem/52357508.

Oh, I should drop this comment too. I am currently validating that my patch did not regress what rdar://problem/52357508 was trying to fix, before I land this.
Comment 6 Chris Dumez 2019-07-12 14:04:35 PDT 
Comment on attachment 374029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374029&action=review

>> Source/WebKit/UIProcess/WebPageProxy.cpp:1061
>>      // FIXME: universal file read access should be set if the sandbox extension is successfully created: rdar://problem/52357508.
> 
> Oh, I should drop this comment too. I am currently validating that my patch did not regress what rdar://problem/52357508 was trying to fix, before I land this.

Ok, I have confirmed that rdar://problem/52357508 is also fixed with my patch. I'll drop the FIXME comment before landing.
Comment 7 Chris Dumez 2019-07-12 14:06:00 PDT 
Created attachment 374034 [details]
Patch
Comment 8 WebKit Commit Bot 2019-07-12 15:03:33 PDT 
Comment on attachment 374034 [details]
Patch

Clearing flags on attachment: 374034

Committed r247400: <https://trac.webkit.org/changeset/247400>
Comment 9 WebKit Commit Bot 2019-07-12 15:03:35 PDT 
All reviewed patches have been landed.  Closing bug.