Bug 199749

Summary: [MSE] Reenqueue after removeCodedFrames()
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: MediaAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alicia Boya García
Reported 2019-07-12 03:29:32 PDT
Before this patch, SourceBuffer::removeCodedFrames() did not trigger an immediate reenqueue, but rather just set the `needsReenqueuing` flag, deferring it for the next append... but there may not be another append! In that case, the removed frames would still wrongly play. This is the case for instance in tests where a single long media append is done and then "cropped" with SourceBuffer.erase(). Test: media/media-source/media-source-erase-after-last-append.html
Attachments
Patch (7.60 KB, patch)
2019-07-12 03:31 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Patch (7.60 KB, patch)
2019-07-16 05:19 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Patch (7.61 KB, patch)
2019-07-24 09:55 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2019-07-12 03:31:18 PDT
Created attachment 374002 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2019-07-15 06:35:04 PDT
Comment on attachment 374002 [details] Patch I see it ok, so r+. Then we have Apple EWS going very red on this, so maybe you check why and wait for Jer and Eric so say something as well.
Alicia Boya García
Comment 3 2019-07-16 04:40:25 PDT
It's failing because it's missing the AtomicString -> AtomString rename, I'll re-upload with that fixed as soon as I clean up my git finishing changes in the WebKitMediaSrc patch.
Alicia Boya García
Comment 4 2019-07-16 05:19:26 PDT
Created attachment 374205 [details] Patch
WebKit Commit Bot
Comment 5 2019-07-24 09:32:33 PDT
Comment on attachment 374205 [details] Patch Rejecting attachment 374205 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 374205, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/12801817
Alicia Boya García
Comment 6 2019-07-24 09:55:02 PDT
Created attachment 374785 [details] Patch
WebKit Commit Bot
Comment 7 2019-07-24 11:13:12 PDT
Comment on attachment 374785 [details] Patch Clearing flags on attachment: 374785 Committed r247783: <https://trac.webkit.org/changeset/247783>
WebKit Commit Bot
Comment 8 2019-07-24 11:13:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-07-24 11:14:22 PDT
<rdar://problem/53504713>
Note You need to log in before you can comment on or make changes to this bug.