Bug 199748

Summary:

[ATK] Avoid unneeded call to to core(selection) in listObjectForSelection()

Product:

WebKit

Reporter:

Adrian Perez <aperez>

Component:

Accessibility

Assignee:

Adrian Perez <aperez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, annulen, aperez, apinheiro, bugs-noreply, cfleizach, cgarcia, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, mario, mcatanzaro, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

104114

Attachments:

Description	Flags
Patch	none

Description Adrian Perez 2019-07-12 01:34:45 PDT

In Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:

The “coreSelection“ returned by “core()” is already null-checked inside
“optionFromList()” before calling “listObjectForSelection”, and this is
the only call site. While technically there is no issue here, a small
refactoring could be done to pass “coreSelection” to it, instead of
passing the plain “selection” and needing to call “core(selection)”
multiple times.

Comment 1 Radar WebKit Bug Importer 2019-07-12 01:35:02 PDT

<rdar://problem/52995908>

Comment 2 Adrian Perez 2019-07-12 01:43:06 PDT

Created attachment 374001 [details]
Patch

Comment 3 WebKit Commit Bot 2019-07-12 03:09:03 PDT

Comment on attachment 374001 [details]
Patch

Clearing flags on attachment: 374001

Committed r247384: <https://trac.webkit.org/changeset/247384>

Comment 4 WebKit Commit Bot 2019-07-12 03:09:05 PDT

All reviewed patches have been landed.  Closing bug.