Bug 199739

Summary: Turn off two finger gestures for editable non-scaled content
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Megan Gardner
Reported 2019-07-11 17:32:06 PDT
Turn off two finger gestures for editable non-scaled content
Attachments
Patch (6.10 KB, patch)
2019-07-11 17:33 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (6.27 KB, patch)
2019-07-11 17:34 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.29 KB, patch)
2019-07-12 15:38 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (2.17 KB, patch)
2019-07-12 17:55 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.16 KB, patch)
2019-07-12 18:08 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2019-07-11 17:33:42 PDT
Created attachment 373981 [details] Patch
Megan Gardner
Comment 2 2019-07-11 17:34:06 PDT
Created attachment 373982 [details] Patch
Megan Gardner
Comment 3 2019-07-11 17:34:33 PDT
<rdar://problem/52107190>
Tim Horton
Comment 4 2019-07-11 22:22:28 PDT
Comment on attachment 373982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373982&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-763 > - _twoFingerDoubleTapGestureRecognizer = adoptNS([[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(_twoFingerDoubleTapRecognized:)]); Why did two finger double tap code move? It's still clearly called (by the line just prior to this), and not disabled anywhere, so this seems pointless? But maybe I'm missing something. > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:806 > + if (!_webView._editable) I have a Question! Presumably single-finger-single-tap on links is also disabled in editable contexts... how is that achieved? Can this follow the same path? (maybe not!) > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3967 > +- (void)_setTwoFingerSingleTapGesturesEnabled:(BOOL)enabled > +{ > + [_twoFingerSingleTapGestureRecognizer setEnabled:enabled]; > +} This seems like a rather unnecessary method.
Megan Gardner
Comment 5 2019-07-12 15:38:43 PDT
Created attachment 374044 [details] Patch
Megan Gardner
Comment 6 2019-07-12 17:55:30 PDT
Created attachment 374057 [details] Patch
Tim Horton
Comment 7 2019-07-12 18:00:13 PDT
Comment on attachment 374057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374057&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:793 > + [_twoFingerSingleTapGestureRecognizer setEnabled:!_webView._editable]; I am sold! Though I would probably put it before the add, with all the other setters.
Megan Gardner
Comment 8 2019-07-12 18:08:28 PDT
Created attachment 374061 [details] Patch for landing
WebKit Commit Bot
Comment 9 2019-07-12 18:50:32 PDT
Comment on attachment 374061 [details] Patch for landing Clearing flags on attachment: 374061 Committed r247411: <https://trac.webkit.org/changeset/247411>
WebKit Commit Bot
Comment 10 2019-07-12 18:50:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.