Bug 199737

Summary:

window.openDatabase is not writable

Product:

WebKit

Reporter:

Sihui Liu <sihui_liu>

Component:

New Bugs

Assignee:

Sihui Liu <sihui_liu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, esprehn+autocc, ews-watchlist, ggaren, kondapallykalyan, sam, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none
Patch for landing	none
Patch for landing	none

Description Sihui Liu 2019-07-11 17:08:23 PDT

...

Comment 1 Sihui Liu 2019-07-11 17:09:01 PDT

<rdar://problem/52551332>

Comment 2 Sihui Liu 2019-07-11 17:13:41 PDT

Created attachment 373977 [details]
Patch

Comment 3 Chris Dumez 2019-07-12 10:21:16 PDT

Comment on attachment 373977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373977&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html:18
> +                if (window.openDatabase == func) {

===

Comment 4 Sihui Liu 2019-07-12 11:40:35 PDT

Created attachment 374025 [details]
Patch for landing

Comment 5 Sam Weinig 2019-07-12 14:52:01 PDT

Comment on attachment 374025 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=374025&action=review

> Source/WebCore/ChangeLog:13
> +        Modified API test: WebSQL.OpenDatabaseAlwaysExists
> +
> +        * Modules/webdatabase/DOMWindowWebDatabase.idl:
> +        * bindings/js/JSDOMWindowCustom.cpp:
> +        (WebCore::JSDOMWindow::setOpenDatabase):

This really needs an explanation. Please do try to explain what the change is doing and why in the ChangeLog.

Comment 6 Sihui Liu 2019-07-12 16:44:05 PDT

Created attachment 374053 [details]
Patch for landing

Comment 7 Sihui Liu 2019-07-12 16:46:48 PDT

Created attachment 374054 [details]
Patch for landing

Comment 8 WebKit Commit Bot 2019-07-12 16:50:29 PDT

Comment on attachment 374054 [details]
Patch for landing

Rejecting attachment 374054 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 374054, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/12728934

Comment 9 Sihui Liu 2019-07-15 09:34:46 PDT

Created attachment 374116 [details]
Patch for landing

Comment 10 WebKit Commit Bot 2019-07-15 10:17:59 PDT

Comment on attachment 374116 [details]
Patch for landing

Clearing flags on attachment: 374116

Committed r247434: <https://trac.webkit.org/changeset/247434>

Comment 11 WebKit Commit Bot 2019-07-15 10:18:00 PDT

All reviewed patches have been landed.  Closing bug.