| Summary: | Begin unifying WebKitLegacy sources | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, keith_miller, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2019-07-11 15:46:03 PDT
Created attachment 373967 [details]
Patch
Created attachment 373979 [details]
Patch
Created attachment 374019 [details]
Patch
Comment on attachment 374019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374019&action=review r=me with comment. > Source/WebKitLegacy/scripts/generate-unified-sources.sh:21 > + echo "Using unified source list files: Sources.txt, SourcesCocoa.txt" Is there a way to make this echo use the same values that are passed to the generate-unified-source-bundles.rb call below? Comment on attachment 374019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374019&action=review >> Source/WebKitLegacy/scripts/generate-unified-sources.sh:21 >> + echo "Using unified source list files: Sources.txt, SourcesCocoa.txt" > > Is there a way to make this echo use the same values that are passed to the generate-unified-source-bundles.rb call below? If that's important we should make JavaScriptCore and WebCore do the same thing in a different patch. Comment on attachment 374019 [details] Patch Clearing flags on attachment: 374019 Committed r247401: <https://trac.webkit.org/changeset/247401> All reviewed patches have been landed. Closing bug. |