Bug 199730

Summary: Begin unifying WebKitLegacy sources
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2019-07-11 15:46:03 PDT
Begin unifying WebKitLegacy sources
Attachments
Patch (27.16 KB, patch)
2019-07-11 15:46 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (28.44 KB, patch)
2019-07-11 17:25 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (29.23 KB, patch)
2019-07-12 10:27 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-07-11 15:46:14 PDT
Created attachment 373967 [details] Patch
Alex Christensen
Comment 2 2019-07-11 17:25:07 PDT
Created attachment 373979 [details] Patch
Alex Christensen
Comment 3 2019-07-12 10:27:24 PDT
Created attachment 374019 [details] Patch
Keith Miller
Comment 4 2019-07-12 14:09:16 PDT
Comment on attachment 374019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374019&action=review r=me with comment. > Source/WebKitLegacy/scripts/generate-unified-sources.sh:21 > + echo "Using unified source list files: Sources.txt, SourcesCocoa.txt" Is there a way to make this echo use the same values that are passed to the generate-unified-source-bundles.rb call below?
Alex Christensen
Comment 5 2019-07-12 14:16:33 PDT
Comment on attachment 374019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374019&action=review >> Source/WebKitLegacy/scripts/generate-unified-sources.sh:21 >> + echo "Using unified source list files: Sources.txt, SourcesCocoa.txt" > > Is there a way to make this echo use the same values that are passed to the generate-unified-source-bundles.rb call below? If that's important we should make JavaScriptCore and WebCore do the same thing in a different patch.
WebKit Commit Bot
Comment 6 2019-07-12 15:08:09 PDT
Comment on attachment 374019 [details] Patch Clearing flags on attachment: 374019 Committed r247401: <https://trac.webkit.org/changeset/247401>
WebKit Commit Bot
Comment 7 2019-07-12 15:08:10 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-07-12 15:09:21 PDT
<rdar://problem/53029166>
Note You need to log in before you can comment on or make changes to this bug.