Bug 199729

Summary: API tests using permanent credentials should clear credentials left by previous tests
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: Tools / TestsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, achristensen, ap, cdumez, commit-queue, ews-watchlist, ggaren, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews117 for mac-highsierra none

Sihui Liu
Reported 2019-07-11 15:06:05 PDT
... because there might be test credentials left from last run somehow, and without clearing them, the test would timeout.
Attachments
Patch (19.64 KB, patch)
2019-07-19 11:58 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews117 for mac-highsierra (3.43 MB, application/zip)
2019-07-19 15:20 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2019-07-19 11:58:56 PDT
Created attachment 374484 [details] Patch
EWS Watchlist
Comment 2 2019-07-19 15:20:29 PDT
Comment on attachment 374484 [details] Patch Attachment 374484 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12775132 New failing tests: webgl/2.0.0/conformance/context/context-release-upon-reload.html
EWS Watchlist
Comment 3 2019-07-19 15:20:30 PDT
Created attachment 374506 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Sihui Liu
Comment 4 2019-07-19 16:30:10 PDT
This test failure should be unrelated. My patch only changed SPI for API tests and API tests that are affected.
Aakash Jain
Comment 5 2019-08-02 13:02:21 PDT
Another example. It seems like Patch 375113 left the bot (ews119) in bad state in https://ews-build.webkit.org/#/builders/3/builds/5406 and subsequent API test runs on ews119 kept failing 3 API tests (Challenge.BasicProposedCredential, WKWebsiteDataStore.FetchPersistentCredentials, Challenge.SecIdentity), until the machine just got in a very bad state and had to be rebooted and keychain entries for 127.0.0.1 manually removed.
WebKit Commit Bot
Comment 6 2019-08-02 14:19:57 PDT
Comment on attachment 374484 [details] Patch Clearing flags on attachment: 374484 Committed r248181: <https://trac.webkit.org/changeset/248181>
WebKit Commit Bot
Comment 7 2019-08-02 14:19:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-08-02 14:20:20 PDT
<rdar://problem/53879414>
Note You need to log in before you can comment on or make changes to this bug.