Summary: | MobileSafari may crash under -[UIKeyboardTaskExecutionContext transferExecutionToMainThreadWithTask:] | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||
Component: | HTML Editing | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bdakin, cdumez, commit-queue, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Wenson Hsieh
2019-07-10 20:46:23 PDT
Created attachment 373903 [details]
Test
Created attachment 373904 [details]
Patch
Maybe we want a helper “dispatch failed to fetch autocorrection context if needed” (not a good name but you get the idea). to make the sending empty data more semantically clear at callers, since there are now at least three (In reply to Tim Horton from comment #3) > Maybe we want a helper “dispatch failed to fetch autocorrection context if > needed” (not a good name but you get the idea). to make the sending empty > data more semantically clear at callers, since there are now at least three Makes sense! I’ll add a _cancelPendingAutocorrectionContextHandler, and adopt it in the few places that call the completion handler with empty info. Created attachment 373906 [details]
Patch for landing
Comment on attachment 373906 [details] Patch for landing Clearing flags on attachment: 373906 Committed r247345: <https://trac.webkit.org/changeset/247345> All reviewed patches have been landed. Closing bug. |