Bug 19970

Summary: PluginView/Win32 does not compile with MinGW
Product: WebKit Reporter: Ariya Hidayat <ariya.hidayat>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
patch to fix the problem (as discussed with aroben and andersca) aroben: review+

Ariya Hidayat
Reported 2008-07-10 03:50:53 PDT
The following line causes problem: friend static LRESULT CALLBACK PluginViewWndProc(HWND, UINT, WPARAM, LPARAM); since gcc 3.4.5 (on latest stable MinGW) chokes on that.
Attachments
patch to fix the problem (as discussed with aroben and andersca) (2.67 KB, patch)
2008-07-10 04:02 PDT, Ariya Hidayat 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ariya Hidayat
Comment 1 2008-07-10 04:02:32 PDT
Created attachment 22198 [details] patch to fix the problem (as discussed with aroben and andersca)
Adam Roben (:aroben)
Comment 2 2008-07-10 08:04:43 PDT
Comment on attachment 22198 [details] patch to fix the problem (as discussed with aroben and andersca) r=me
Ariya Hidayat
Comment 3 2008-07-14 02:27:29 PDT
Landed in r35124
Note You need to log in before you can comment on or make changes to this bug.