| Summary: | Drop non thread-safe usage of WeakPtr in PlaybackSessionInterfaceAVKit | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | Media | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, eric.carlson, ggaren, jer.noble, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=195935 https://bugs.webkit.org/show_bug.cgi?id=199775 |
||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 199639 | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2019-07-10 19:34:12 PDT
Created attachment 373898 [details]
Patch
Comment on attachment 373898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373898&action=review I’m not comfortable with this change unless we add some release asserts to prevent this member from being in an invalid state. I can talk to you in person next week if you want background on why this is important. > Source/WebCore/ChangeLog:14 > + purposes (Not trying to address a particular crash). I think your patch should include release-asserts that the pointer is in a safe state when assigned, when being destroyed, etc. Created attachment 373939 [details]
Patch
Comment on attachment 373939 [details] Patch Clearing flags on attachment: 373939 Committed r247380: <https://trac.webkit.org/changeset/247380> All reviewed patches have been landed. Closing bug. |