Bug 199696

Summary:

Long pressing on attachments will crash the WebContent process

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, simon.fraser, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Tim Horton 2019-07-10 18:47:00 PDT

Long pressing on attachments will crash the WebContent process

Comment 1 Tim Horton 2019-07-10 18:47:56 PDT

Created attachment 373890 [details]
Patch

Comment 2 Tim Horton 2019-07-10 18:47:57 PDT

<rdar://problem/52920241>

Comment 3 Dean Jackson 2019-07-10 18:56:17 PDT

Comment on attachment 373890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373890&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2667
> +        linkIndicatorPositionInformation(page, attachment, request, info);

Less than perfect name for a function (there are many like this in the file).

Comment 4 Tim Horton 2019-07-10 20:39:02 PDT

(In reply to Dean Jackson from comment #3)
> Comment on attachment 373890 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373890&action=review
> 
> > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2667
> > +        linkIndicatorPositionInformation(page, attachment, request, info);
> 
> Less than perfect name for a function (there are many like this in the file).

Said introduced them recently, it all still needs baking but at least it’s not a giant function anymore.

Comment 5 WebKit Commit Bot 2019-07-10 21:09:58 PDT

Comment on attachment 373890 [details]
Patch

Clearing flags on attachment: 373890

Committed r247342: <https://trac.webkit.org/changeset/247342>

Comment 6 WebKit Commit Bot 2019-07-10 21:09:59 PDT

All reviewed patches have been landed.  Closing bug.