Bug 199696 – Long pressing on attachments will crash the WebContent process

• Component: New Bugs
• Status: RESOLVED FIXED

[Tim Horton]

Long pressing on attachments will crash the WebContent process

[Tim Horton]

Created attachment 373890 [details]
Patch

[Tim Horton]

<rdar://problem/52920241>

[Dean Jackson]

Comment on attachment 373890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373890&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2667
> +        linkIndicatorPositionInformation(page, attachment, request, info);

Less than perfect name for a function (there are many like this in the file).

[Tim Horton]

(In reply to Dean Jackson from comment #3)
> Comment on attachment 373890 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373890&action=review
> 
> > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2667
> > +        linkIndicatorPositionInformation(page, attachment, request, info);
> 
> Less than perfect name for a function (there are many like this in the file).

Said introduced them recently, it all still needs baking but at least it’s not a giant function anymore.

[WebKit Commit Bot]

Comment on attachment 373890 [details]
Patch

Clearing flags on attachment: 373890

Committed r247342: <https://trac.webkit.org/changeset/247342>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.