Bug 199696 - Long pressing on attachments will crash the WebContent process
Summary: Long pressing on attachments will crash the WebContent process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-10 18:47 PDT by Tim Horton
Modified: 2019-07-10 21:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.80 KB, patch)
2019-07-10 18:47 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-07-10 18:47:00 PDT 
Long pressing on attachments will crash the WebContent process
Comment 1 Tim Horton 2019-07-10 18:47:56 PDT 
Created attachment 373890 [details]
Patch
Comment 2 Tim Horton 2019-07-10 18:47:57 PDT 
<rdar://problem/52920241>
Comment 3 Dean Jackson 2019-07-10 18:56:17 PDT 
Comment on attachment 373890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373890&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2667
> +        linkIndicatorPositionInformation(page, attachment, request, info);

Less than perfect name for a function (there are many like this in the file).
Comment 4 Tim Horton 2019-07-10 20:39:02 PDT 
(In reply to Dean Jackson from comment #3)
> Comment on attachment 373890 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373890&action=review
> 
> > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2667
> > +        linkIndicatorPositionInformation(page, attachment, request, info);
> 
> Less than perfect name for a function (there are many like this in the file).

Said introduced them recently, it all still needs baking but at least it’s not a giant function anymore.
Comment 5 WebKit Commit Bot 2019-07-10 21:09:58 PDT 
Comment on attachment 373890 [details]
Patch

Clearing flags on attachment: 373890

Committed r247342: <https://trac.webkit.org/changeset/247342>
Comment 6 WebKit Commit Bot 2019-07-10 21:09:59 PDT 
All reviewed patches have been landed.  Closing bug.