Bug 199695

Summary: [WHLSL] Optional<UniqueRef<T>> -> std::unique_ptr in Return/IfStatement/ForLoop
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: WebGPUAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 199389    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Robin Morisset
Reported 2019-07-10 18:17:39 PDT
Same reasoning as https://bugs.webkit.org/show_bug.cgi?id=199389 Saves 8 bytes per If/Return, 16 bytes per For, and the patch is trivial.
Attachments
Patch (7.18 KB, patch)
2019-07-10 18:21 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Patch (8.30 KB, patch)
2019-07-10 18:22 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-07-10 18:21:05 PDT
Created attachment 373886 [details] Patch
Robin Morisset
Comment 2 2019-07-10 18:22:56 PDT
Created attachment 373887 [details] Patch
WebKit Commit Bot
Comment 3 2019-07-10 19:09:58 PDT
Comment on attachment 373887 [details] Patch Clearing flags on attachment: 373887 Committed r247341: <https://trac.webkit.org/changeset/247341>
WebKit Commit Bot
Comment 4 2019-07-10 19:09:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-07-10 19:10:26 PDT
<rdar://problem/52927323>
Note You need to log in before you can comment on or make changes to this bug.