Summary: | [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aestes, cmarcelo, ews-watchlist, fred.wang, jamesr, koivisto, luiz, rniwa, simon.fraser, thorton, tonikitoo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=236561 | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2019-07-10 17:46:08 PDT
Created attachment 373882 [details]
Patch
Attachment 373882 [details] did not pass style-queue:
ERROR: Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h:47: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
ERROR: Source/WebKit/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKit/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKit/ChangeLog:12: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:12: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 7 in 19 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 373882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373882&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2029 > + bool scrollingNeededToRevealUI = false; I don't know that this is the best name (nor do I love the changelog wording). Could be more abstractly worded. > Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:2 > + * Copyright (C) 2018 Apple Inc. All rights reserved. alas, it is not 2018. it's barely even 2019 anymore Comment on attachment 373882 [details] Patch Attachment 373882 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12711820 New failing tests: fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolling-layers-state.html fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-then-up.html fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down.html Created attachment 373895 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
|