Bug 19966

Summary:

CSS variables crash when using hex notation for colors

Product:

WebKit

Reporter:

boucher <rboucher>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hyatt

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.5

URL:

http://rossboucher.com/test/index.html

Attachments:

Description	Flags
First attempt	mitz: review+

boucher

Reported 2008-07-09 14:13:29 PDT

The new CSS variable mechanism will crash if you specify a color variable using hex (#) notation. The URL attached has a simple test case. The offending line: @-webkit-variables { defaultTextColor: #333; }

Attachments
First attempt (17.09 KB, patch) 2008-07-12 06:44 PDT, Rob Buis	mitz: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2008-07-12 06:44:44 PDT

Created attachment 22255 [details] First attempt From the testcase and spec example I guess hex colors should be supported, this fixes that. I wonder whether there are more CSSPrimitiveValues that are not supported for the css variables... Cheers, Rob.

mitz

Comment 2 2008-07-20 14:32:42 PDT

Comment on attachment 22255 [details] First attempt The code changes look good, but please consider changing the test to dump as text, using getComputedStyle. Thanks!

Rob Buis

Comment 3 2008-07-22 01:28:57 PDT

Landed in r35272.

Note You need to log in before you can comment on or make changes to this bug.