Bug 199651

Summary: [WHLSL] Import more JS reference spec tests
Product: WebKit Reporter: Saam Barati <saam>
Component: WebGPUAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 199595    
Attachments:
Description Flags
patch
none
patch
none
patch for landing none

Description Saam Barati 2019-07-09 19:08:07 PDT 
...
Comment 1 Saam Barati 2019-07-09 19:12:23 PDT 
Created attachment 373808 [details]
patch
Comment 2 Saam Barati 2019-07-09 19:32:35 PDT 
Created attachment 373811 [details]
patch
Comment 3 Saam Barati 2019-07-10 11:49:29 PDT 
Rubber stamped by Robin
Comment 4 Saam Barati 2019-07-10 11:50:32 PDT 
Created attachment 373852 [details]
patch for landing
Comment 5 WebKit Commit Bot 2019-07-10 13:02:01 PDT 
Comment on attachment 373852 [details]
patch for landing

Clearing flags on attachment: 373852

Committed r247319: <https://trac.webkit.org/changeset/247319>
Comment 6 WebKit Commit Bot 2019-07-10 13:02:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-07-10 13:03:21 PDT 
<rdar://problem/52908330>
Comment 8 Truitt Savell 2019-07-10 15:52:21 PDT 
It looks like the new test added in https://trac.webkit.org/changeset/247319/webkit

webgpu/whlsl-builtin-vectors-2.html

is timing out.

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgpu%2Fwhlsl-builtin-vectors-2.html
Comment 9 Truitt Savell 2019-07-10 17:07:04 PDT 
Same asked offline for me to mark the test slow. Marked as slow for Mojave Debug WK2 in:
https://trac.webkit.org/changeset/247333/webkit
Comment 10 Truitt Savell 2019-07-11 07:37:53 PDT 
Marking slow has allowed the test to start passing.