| Summary: | [WHLSL] Import another round of JS spec tests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
| Component: | WebGPU | Assignee: | Saam Barati <saam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 199595 | ||||||||
| Attachments: |
|
||||||||
|
Description
Saam Barati
2019-07-09 16:32:32 PDT
Created attachment 373789 [details]
patch
Comment on attachment 373789 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=373789&action=review > LayoutTests/webgpu/whlsl-float-math.html:19 > + bool foo2() I don't understand, how is foo2() different from foo() ? And from foo3, 4 and 5? > LayoutTests/webgpu/whlsl-float-math.html:41 > + return bar(7.5); Same between foo6 and foo7 > LayoutTests/webgpu/whlsl-float-math.html:49 > + return float(7.5); Same between foo9 and foo10 > LayoutTests/webgpu/whlsl-float-math.html:102 > + await checkFail( Again, this test is a duplicate of the previous one. Created attachment 373797 [details]
patch
Comment on attachment 373797 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=373797&action=review > LayoutTests/webgpu/whlsl-bad-ander.html:1 > +<!DOCTYPE html><!-- webkit-test-runner [ experimental:WebGPUEnabled=true ] --> Shouldn't need this webkit-test-runner comment on any test. (In reply to Myles C. Maxfield from comment #4) > Comment on attachment 373797 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373797&action=review > > > LayoutTests/webgpu/whlsl-bad-ander.html:1 > > +<!DOCTYPE html><!-- webkit-test-runner [ experimental:WebGPUEnabled=true ] --> > > Shouldn't need this webkit-test-runner comment on any test. Will remove from all tests inside webgpu/ |