Bug 199647

Summary: [WHLSL] Import another round of JS spec tests
Product: WebKit Reporter: Saam Barati <saam>
Component: WebGPUAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 199595    
Attachments:
Description Flags
patch
none
patch mmaxfield: review+

Saam Barati
Reported 2019-07-09 16:32:32 PDT
...
Attachments
patch (26.34 KB, patch)
2019-07-09 16:36 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (25.06 KB, patch)
2019-07-09 17:14 PDT, Saam Barati 		mmaxfield: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-07-09 16:36:54 PDT
Created attachment 373789 [details] patch
Robin Morisset
Comment 2 2019-07-09 17:04:37 PDT
Comment on attachment 373789 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=373789&action=review > LayoutTests/webgpu/whlsl-float-math.html:19 > + bool foo2() I don't understand, how is foo2() different from foo() ? And from foo3, 4 and 5? > LayoutTests/webgpu/whlsl-float-math.html:41 > + return bar(7.5); Same between foo6 and foo7 > LayoutTests/webgpu/whlsl-float-math.html:49 > + return float(7.5); Same between foo9 and foo10 > LayoutTests/webgpu/whlsl-float-math.html:102 > + await checkFail( Again, this test is a duplicate of the previous one.
Saam Barati
Comment 3 2019-07-09 17:14:24 PDT
Created attachment 373797 [details] patch
Myles C. Maxfield
Comment 4 2019-07-09 17:16:50 PDT
Comment on attachment 373797 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=373797&action=review > LayoutTests/webgpu/whlsl-bad-ander.html:1 > +<!DOCTYPE html><!-- webkit-test-runner [ experimental:WebGPUEnabled=true ] --> Shouldn't need this webkit-test-runner comment on any test.
Saam Barati
Comment 5 2019-07-09 17:21:26 PDT
(In reply to Myles C. Maxfield from comment #4) > Comment on attachment 373797 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373797&action=review > > > LayoutTests/webgpu/whlsl-bad-ander.html:1 > > +<!DOCTYPE html><!-- webkit-test-runner [ experimental:WebGPUEnabled=true ] --> > > Shouldn't need this webkit-test-runner comment on any test. Will remove from all tests inside webgpu/
Saam Barati
Comment 6 2019-07-09 17:23:40 PDT
landed in: https://trac.webkit.org/changeset/247289/webkit
Radar WebKit Bug Importer
Comment 7 2019-07-09 17:43:50 PDT
<rdar://problem/52862550>
Note You need to log in before you can comment on or make changes to this bug.