Summary: | TestWebKitAPI.ProcessSwap.QuickBackForwardNavigationWithPSON is a flaky crash | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | New Bugs | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, beidson, cdumez, commit-queue, ggaren, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryan Haddad
2019-07-09 15:41:41 PDT
This test was added in February with https://trac.webkit.org/changeset/241606/webkit. I don't have a regression point. Created attachment 383644 [details]
Patch
Comment on attachment 383644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383644&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2337 > - EXPECT_EQ(3u, backForwardListURLs.size()); > + RELEASE_ASSERT(backForwardListURLs.size() == 3u); I don't see why this is necessary. Comment on attachment 383644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383644&action=review >> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2337 >> + RELEASE_ASSERT(backForwardListURLs.size() == 3u); > > I don't see why this is necessary. If backForwardListURLs.size() is 2 for example (which I saw locally), it ends up crashing in an obscure fashion later on. I'd rather we crash right away if the list size if wrong. Comment on attachment 383644 [details] Patch Clearing flags on attachment: 383644 Committed r252600: <https://trac.webkit.org/changeset/252600> All reviewed patches have been landed. Closing bug. |