Bug 199639

Summary:

Add threading assertion to WeakPtrFactory::createWeakPtr()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Template Framework

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue, dbates, ews-watchlist, Hironori.Fujii, pvollan, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

199652, 199656, 199698, 199700, 199727, 199775, 199777

Bug Blocks:

199517

Attachments:

Description	Flags
WIP Patch	none
WIP Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews100 for mac-highsierra	none
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Archive of layout-test-results from ews112 for mac-highsierra	none
Archive of layout-test-results from ews214 for win-future	none
WIP Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews213 for win-future	none
WIP Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews213 for win-future	none
WIP Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews214 for win-future	none
WIP Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews212 for win-future	none
WIP Patch	none
Patch	none

Chris Dumez

Reported 2019-07-09 14:02:12 PDT

Add threading assertion to WeakPtrFactory::createWeakPtr().

Attachments
WIP Patch (1.38 KB, patch) 2019-07-09 14:02 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (2.36 KB, patch) 2019-07-09 14:07 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-highsierra (4.53 MB, application/zip) 2019-07-09 15:36 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (4.09 MB, application/zip) 2019-07-09 15:44 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (3.10 MB, application/zip) 2019-07-09 16:21 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-highsierra (4.32 MB, application/zip) 2019-07-09 16:40 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews214 for win-future (13.86 MB, application/zip) 2019-07-09 17:13 PDT, EWS Watchlist	no flags	Details
WIP Patch (2.36 KB, patch) 2019-07-10 10:34 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews213 for win-future (13.65 MB, application/zip) 2019-07-10 13:16 PDT, EWS Watchlist	no flags	Details
WIP Patch (2.36 KB, patch) 2019-07-10 16:18 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews213 for win-future (13.40 MB, application/zip) 2019-07-10 18:55 PDT, EWS Watchlist	no flags	Details
WIP Patch (2.36 KB, patch) 2019-07-11 10:15 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews214 for win-future (13.62 MB, application/zip) 2019-07-11 16:01 PDT, EWS Watchlist	no flags	Details
WIP Patch (2.36 KB, patch) 2019-07-12 08:01 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews212 for win-future (13.35 MB, application/zip) 2019-07-12 10:55 PDT, EWS Watchlist	no flags	Details
WIP Patch (2.36 KB, patch) 2019-07-13 09:16 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (4.11 KB, patch) 2019-07-13 12:45 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (16) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-07-09 14:02:41 PDT

Created attachment 373760 [details] WIP Patch

Chris Dumez

Comment 2 2019-07-09 14:07:03 PDT

Created attachment 373762 [details] WIP Patch

EWS Watchlist

Comment 3 2019-07-09 15:36:27 PDT

Comment on attachment 373762 [details] WIP Patch Attachment 373762 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12701571 New failing tests: fast/block/float/list-marker-is-float-crash.html media/media-source/media-source-seek-redundant-append.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage.html media/audio-data-url.html http/tests/media/clearkey/collect-webkit-media-session.html http/tests/media/media-source/mediasource-play-then-seek-back-with-remote-control.html imported/w3c/web-platform-tests/media-source/mediasource-play.html media/video-src-blob-using-open-panel.html media/sources-fallback-codecs.html http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html imported/w3c/web-platform-tests/media-source/mediasource-redundant-seek.html imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-video-bitrate.html media/media-source/media-source-stalled-holds-sleep-assertion.html http/tests/media/clearkey/clear-key-hls-aes128.html media/unsupported-rtsp.html inspector/console/webcore-logging.html platform/mac/media/media-source/videoplaybackquality-decompressionsession.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html imported/w3c/web-platform-tests/media-source/mediasource-detach.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer.html imported/w3c/web-platform-tests/media-source/mediasource-play-then-seek-back.html imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-audio-bitrate.html media/video-src-blob.html imported/w3c/web-platform-tests/media-source/mediasource-avtracks.html fast/forms/form-associated-element-crash3.html

EWS Watchlist

Comment 4 2019-07-09 15:36:29 PDT

Created attachment 373784 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 5 2019-07-09 15:44:38 PDT

Comment on attachment 373762 [details] WIP Patch Attachment 373762 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12701602 New failing tests: fast/block/float/list-marker-is-float-crash.html media/media-source/media-source-seek-redundant-append.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage.html media/audio-data-url.html http/tests/media/clearkey/collect-webkit-media-session.html http/tests/media/media-source/mediasource-play-then-seek-back-with-remote-control.html imported/w3c/web-platform-tests/media-source/mediasource-play.html media/video-src-blob-using-open-panel.html media/sources-fallback-codecs.html http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html imported/w3c/web-platform-tests/media-source/mediasource-redundant-seek.html imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-video-bitrate.html media/media-source/media-source-stalled-holds-sleep-assertion.html http/tests/media/clearkey/clear-key-hls-aes128.html media/unsupported-rtsp.html inspector/console/webcore-logging.html platform/mac/media/media-source/videoplaybackquality-decompressionsession.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html imported/w3c/web-platform-tests/media-source/mediasource-detach.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer.html imported/w3c/web-platform-tests/media-source/mediasource-play-then-seek-back.html imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-audio-bitrate.html imported/w3c/web-platform-tests/media-source/mediasource-avtracks.html fast/forms/form-associated-element-crash3.html

EWS Watchlist

Comment 6 2019-07-09 15:44:39 PDT

Created attachment 373785 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 7 2019-07-09 16:21:16 PDT

Comment on attachment 373762 [details] WIP Patch Attachment 373762 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12701813 New failing tests: fast/block/float/list-marker-is-float-crash.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer.html media/audio-data-url.html media/unsupported-rtsp.html fast/forms/form-associated-element-crash3.html http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html

EWS Watchlist

Comment 8 2019-07-09 16:21:18 PDT

Created attachment 373788 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

EWS Watchlist

Comment 9 2019-07-09 16:40:42 PDT

Comment on attachment 373762 [details] WIP Patch Attachment 373762 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12702083 New failing tests: fast/block/float/list-marker-is-float-crash.html media/media-source/media-source-seek-redundant-append.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage.html media/audio-data-url.html http/tests/media/clearkey/collect-webkit-media-session.html http/tests/media/media-source/mediasource-play-then-seek-back-with-remote-control.html http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html media/video-src-blob-using-open-panel.html media/sources-fallback-codecs.html imported/w3c/web-platform-tests/media-source/mediasource-play.html imported/w3c/web-platform-tests/media-source/mediasource-redundant-seek.html imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-video-bitrate.html media/media-source/media-source-stalled-holds-sleep-assertion.html http/tests/media/clearkey/clear-key-hls-aes128.html media/unsupported-rtsp.html inspector/console/webcore-logging.html platform/mac/media/media-source/videoplaybackquality-decompressionsession.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html imported/w3c/web-platform-tests/media-source/mediasource-detach.html imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer.html imported/w3c/web-platform-tests/media-source/mediasource-play-then-seek-back.html imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-audio-bitrate.html media/video-src-blob.html fast/forms/form-associated-element-crash3.html

EWS Watchlist

Comment 10 2019-07-09 16:40:44 PDT

Created attachment 373790 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 11 2019-07-09 17:13:21 PDT

Comment on attachment 373762 [details] WIP Patch Attachment 373762 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12702357 New failing tests: fast/replaced/border-radius-clip.html fast/dom/beforeload/remove-video-in-beforeload-listener.html fast/css/relative-position-replaced-in-table-display-crash.html imported/blink/fast/dom/Window/open-window-features-fuzz.html fast/text/international/embed-bidi-style-in-isolate-crash.html fast/dom/focus-shift-crash.html fast/events/media-element-focus-tab.html http/tests/security/canvas-remote-read-remote-video-hls.html fast/events/tabindex-focus-blur-all.html imported/blink/compositing/video/video-controls-layer-creation-squashing.html

EWS Watchlist

Comment 12 2019-07-09 17:13:24 PDT

Created attachment 373796 [details] Archive of layout-test-results from ews214 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Chris Dumez

Comment 13 2019-07-10 10:34:52 PDT

Created attachment 373844 [details] WIP Patch

EWS Watchlist

Comment 14 2019-07-10 13:16:40 PDT

Comment on attachment 373844 [details] WIP Patch Attachment 373844 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12709173 New failing tests: fast/replaced/border-radius-clip.html fast/events/media-element-focus-tab.html fast/css/relative-position-replaced-in-table-display-crash.html imported/blink/fast/dom/Window/open-window-features-fuzz.html fast/text/international/embed-bidi-style-in-isolate-crash.html fast/dom/focus-shift-crash.html fast/dom/beforeload/remove-video-in-beforeload-listener.html http/tests/security/canvas-remote-read-remote-video-hls.html fast/events/tabindex-focus-blur-all.html imported/blink/compositing/video/video-controls-layer-creation-squashing.html

EWS Watchlist

Comment 15 2019-07-10 13:16:43 PDT

Created attachment 373860 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Chris Dumez

Comment 16 2019-07-10 16:18:51 PDT

Created attachment 373873 [details] WIP Patch

EWS Watchlist

Comment 17 2019-07-10 18:55:06 PDT

Comment on attachment 373873 [details] WIP Patch Attachment 373873 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12711308 New failing tests: fast/replaced/border-radius-clip.html fast/dom/beforeload/remove-video-in-beforeload-listener.html fast/css/relative-position-replaced-in-table-display-crash.html imported/blink/fast/dom/Window/open-window-features-fuzz.html fast/text/international/embed-bidi-style-in-isolate-crash.html fast/dom/focus-shift-crash.html fast/events/media-element-focus-tab.html http/tests/security/canvas-remote-read-remote-video-hls.html fast/events/tabindex-focus-blur-all.html imported/blink/compositing/video/video-controls-layer-creation-squashing.html

EWS Watchlist

Comment 18 2019-07-10 18:55:08 PDT

Created attachment 373891 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Chris Dumez

Comment 19 2019-07-10 19:39:58 PDT

I have a fix for the remaining api-is failures at Bug 199698. This leaves the win failures which I have unable to fix at the moment because win-EWS does not upload crash traces :(

Chris Dumez

Comment 20 2019-07-11 10:15:52 PDT

Created attachment 373925 [details] WIP Patch

EWS Watchlist

Comment 21 2019-07-11 16:01:48 PDT

Comment on attachment 373925 [details] WIP Patch Attachment 373925 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12718500 New failing tests: fast/replaced/border-radius-clip.html fast/dom/beforeload/remove-video-in-beforeload-listener.html fast/css/relative-position-replaced-in-table-display-crash.html imported/blink/fast/dom/Window/open-window-features-fuzz.html fast/text/international/embed-bidi-style-in-isolate-crash.html fast/dom/focus-shift-crash.html fast/events/media-element-focus-tab.html http/tests/security/canvas-remote-read-remote-video-hls.html fast/events/tabindex-focus-blur-all.html imported/blink/compositing/video/video-controls-layer-creation-squashing.html

EWS Watchlist

Comment 22 2019-07-11 16:01:50 PDT

Created attachment 373969 [details] Archive of layout-test-results from ews214 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Chris Dumez

Comment 23 2019-07-12 08:01:32 PDT

Created attachment 374011 [details] WIP Patch

EWS Watchlist

Comment 24 2019-07-12 10:54:59 PDT

Comment on attachment 374011 [details] WIP Patch Attachment 374011 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12725921 New failing tests: fast/replaced/border-radius-clip.html fast/events/media-element-focus-tab.html fast/css/relative-position-replaced-in-table-display-crash.html imported/blink/fast/dom/Window/open-window-features-fuzz.html fast/text/international/embed-bidi-style-in-isolate-crash.html fast/dom/focus-shift-crash.html fast/dom/beforeload/remove-video-in-beforeload-listener.html http/tests/security/canvas-remote-read-remote-video-hls.html fast/events/tabindex-focus-blur-all.html imported/blink/compositing/video/video-controls-layer-creation-squashing.html

EWS Watchlist

Comment 25 2019-07-12 10:55:02 PDT

Created attachment 374021 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Chris Dumez

Comment 26 2019-07-13 09:16:22 PDT

Created attachment 374078 [details] WIP Patch Hoping for green bubbles all around.

Chris Dumez

Comment 27 2019-07-13 12:45:44 PDT

Created attachment 374080 [details] Patch

WebKit Commit Bot

Comment 28 2019-07-14 15:18:09 PDT

Comment on attachment 374080 [details] Patch Clearing flags on attachment: 374080 Committed r247425: <https://trac.webkit.org/changeset/247425>

WebKit Commit Bot

Comment 29 2019-07-14 15:18:11 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 30 2019-07-14 15:19:35 PDT

<rdar://problem/53081768>

Note You need to log in before you can comment on or make changes to this bug.