| Summary: | Stopping a cloned MediaStream video track should not stop any other video track | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
youenn fablet
2019-07-09 12:33:26 PDT
Created attachment 373763 [details]
Patch
Attachment 373763 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:236: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 373763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373763&action=review > Source/WebCore/platform/mediastream/RealtimeMediaSource.h:112 > + virtual void requestToEnd(Observer& callingObserver); Is this change necessary? Comment on attachment 373763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373763&action=review >> Source/WebCore/platform/mediastream/RealtimeMediaSource.h:112 >> + virtual void requestToEnd(Observer& callingObserver); > > Is this change necessary? Unfortunately yes. We might want to improve the model at some point to remove this. Comment on attachment 373763 [details] Patch Clearing flags on attachment: 373763 Committed r247391: <https://trac.webkit.org/changeset/247391> All reviewed patches have been landed. Closing bug. |