Bug 199616

Summary:

Remove rel=subresource tests

Product:

WebKit

Reporter:

Rob Buis <rbuis>

Component:

Page Loading

Assignee:

Rob Buis <rbuis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, bfulgham, commit-queue, ews-watchlist, rniwa, webkit-bug-importer, yoav

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Patch	none
Patch	none

Rob Buis

Reported 2019-07-09 04:11:39 PDT

Subresource was attempted to be removed here (https://bugs.webkit.org/show_bug.cgi?id=183540) but not everything was removed.

Attachments
Patch (16.96 KB, patch) 2019-07-09 04:22 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (15.43 KB, patch) 2019-07-09 04:23 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.70 MB, application/zip) 2019-07-09 05:42 PDT, EWS Watchlist	no flags	Details
Patch (11.46 KB, patch) 2019-07-09 06:06 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.19 MB, application/zip) 2019-07-09 07:14 PDT, EWS Watchlist	no flags	Details
Patch (8.21 KB, patch) 2019-07-09 07:53 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (8.21 KB, patch) 2019-07-09 11:00 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2019-07-09 04:22:04 PDT

Created attachment 373706 [details] Patch

Rob Buis

Comment 2 2019-07-09 04:23:46 PDT

Created attachment 373707 [details] Patch

EWS Watchlist

Comment 3 2019-07-09 05:42:39 PDT

Comment on attachment 373707 [details] Patch Attachment 373707 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12697130 New failing tests: webarchive/test-link-rel-prefetch-beforeload.html

EWS Watchlist

Comment 4 2019-07-09 05:42:40 PDT

Created attachment 373709 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Rob Buis

Comment 5 2019-07-09 06:06:44 PDT

Created attachment 373710 [details] Patch

EWS Watchlist

Comment 6 2019-07-09 07:14:26 PDT

Comment on attachment 373710 [details] Patch Attachment 373710 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12697547 New failing tests: webarchive/test-link-rel-prefetch-beforeload.html

EWS Watchlist

Comment 7 2019-07-09 07:14:28 PDT

Created attachment 373713 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

Rob Buis

Comment 8 2019-07-09 07:53:53 PDT

Created attachment 373719 [details] Patch

Ryosuke Niwa

Comment 9 2019-07-09 10:51:19 PDT

Comment on attachment 373719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373719&action=review > LayoutTests/ChangeLog:3 > + Remove rel=subresource Please update the title here to reflect the fact we're removing tests, not the implementation that had already been removed.

Rob Buis

Comment 10 2019-07-09 11:00:42 PDT

Created attachment 373734 [details] Patch

WebKit Commit Bot

Comment 11 2019-07-09 12:39:00 PDT

Comment on attachment 373734 [details] Patch Clearing flags on attachment: 373734 Committed r247271: <https://trac.webkit.org/changeset/247271>

WebKit Commit Bot

Comment 12 2019-07-09 12:39:02 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 13 2019-07-09 12:43:03 PDT

<rdar://problem/52847467>

Note You need to log in before you can comment on or make changes to this bug.