| Summary: | Web Inspector: Canvas: replace WTF::Vector with std::initializer_list in CallTracer to avoid dynamic allocations | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, rniwa, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Devin Rousso
2019-07-09 01:43:06 PDT
Created attachment 373702 [details]
Patch
Test on bots :)
Created attachment 373720 [details]
Patch
Oops. Forgot to update bindings test :P
Comment on attachment 373720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373720&action=review rs=me > Source/WebCore/ChangeLog:41 > + would otherwise be treated as an array of numbers. Weird whitespace in these ChangeLogs. Comment on attachment 373720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373720&action=review >> Source/WebCore/ChangeLog:41 >> + would otherwise be treated as an array of numbers. > > Weird whitespace in these ChangeLogs. I prefer this, as the "prefix" (e.g. "Drive-by") is much easier to see/identify/read. Comment on attachment 373720 [details] Patch Clearing flags on attachment: 373720 Committed r247278: <https://trac.webkit.org/changeset/247278> All reviewed patches have been landed. Closing bug. |