Bug 199611

Summary: Web Inspector: Canvas: replace WTF::Vector with std::initializer_list in CallTracer to avoid dynamic allocations
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2019-07-09 01:43:06 PDT
.
Attachments
Patch (35.79 KB, patch)
2019-07-09 01:58 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (44.76 KB, patch)
2019-07-09 08:42 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-07-09 01:58:20 PDT
Created attachment 373702 [details] Patch Test on bots :)
Devin Rousso
Comment 2 2019-07-09 08:42:33 PDT
Created attachment 373720 [details] Patch Oops. Forgot to update bindings test :P
Joseph Pecoraro
Comment 3 2019-07-09 13:26:15 PDT
Comment on attachment 373720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373720&action=review rs=me > Source/WebCore/ChangeLog:41 > + would otherwise be treated as an array of numbers. Weird whitespace in these ChangeLogs.
Devin Rousso
Comment 4 2019-07-09 13:37:00 PDT
Comment on attachment 373720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373720&action=review >> Source/WebCore/ChangeLog:41 >> + would otherwise be treated as an array of numbers. > > Weird whitespace in these ChangeLogs. I prefer this, as the "prefix" (e.g. "Drive-by") is much easier to see/identify/read.
WebKit Commit Bot
Comment 5 2019-07-09 14:07:59 PDT
Comment on attachment 373720 [details] Patch Clearing flags on attachment: 373720 Committed r247278: <https://trac.webkit.org/changeset/247278>
WebKit Commit Bot
Comment 6 2019-07-09 14:08:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-07-09 14:08:45 PDT
<rdar://problem/52852082>
Note You need to log in before you can comment on or make changes to this bug.