Summary: | Use WeakHashSet for WebUserContentControllerProxy::m_processes | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, benjamin, cmarcelo, commit-queue, dbates, ews-watchlist, rniwa, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Chris Dumez
2019-07-08 15:15:39 PDT
Created attachment 373672 [details]
Patch
Comment on attachment 373672 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373672&action=review > Source/WebKit/ChangeLog:10 > + stay in the map if we failed to call WebProcessProxy::shutDown() before destroying it. Since we are trying to add/remove the entries in the map properly, should we add some debug asserts that we are actually doing this correctly? Created attachment 373680 [details]
Patch
Created attachment 373681 [details]
Patch
Comment on attachment 373681 [details] Patch Clearing flags on attachment: 373681 Committed r247243: <https://trac.webkit.org/changeset/247243> All reviewed patches have been landed. Closing bug. |