| Summary: | Prevent null dereferencing in SubresourceLoader::init's lambda | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | beidson, cdumez, commit-queue, dbates, ews-watchlist, japhet, rniwa, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=187360 | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2019-07-08 11:18:32 PDT
Created attachment 373646 [details]
Patch
Comment on attachment 373646 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373646&action=review > Source/WebCore/loader/SubresourceLoader.cpp:168 > + ASSERT_NOT_REACHED(); Should we add a release log for this so that if someone complains that the page load doesn't finish, etc... we can check the sysdiagnose and see that this had happened? Comment on attachment 373646 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373646&action=review >> Source/WebCore/loader/SubresourceLoader.cpp:168 >> + ASSERT_NOT_REACHED(); > > Should we add a release log for this so that if someone complains that the page load doesn't finish, etc... we can check the sysdiagnose and see that this had happened? RELEASE_LOG_ERROR(). Created attachment 373667 [details]
Patch
|