Bug 199578

Summary: test-webkitpy: Explicitly use Python 2.7 lldb library
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, dbates, dean_johnson, ews-watchlist, glenn, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jonathan Bedard 2019-07-08 10:57:01 PDT 
In newer versions of Xcode, the default lldb Python library is the Python 3 library, explicitly use the Python 2.7 library.
Comment 1 Jonathan Bedard 2019-07-08 10:57:19 PDT 
<rdar://problem/51853557>
Comment 2 Jonathan Bedard 2019-07-08 11:03:42 PDT 
Created attachment 373643 [details]
Patch
Comment 3 Jonathan Bedard 2019-07-08 11:04:55 PDT 
Might get tripped up by TCC prompts on Catalina, but I think our bots should be fine because they have password-less sudo.
Comment 4 Aakash Jain 2019-07-08 12:09:59 PDT 
Comment on attachment 373643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373643&action=review

> Tools/Scripts/webkitpy/test/main.py:107
>      build_version = _host.platform.build_version()

Do we need this method (_supports_building_and_running_lldb_tests) at all after this change?

Seems like it was added in https://trac.webkit.org/changeset/246662/webkit
Comment 5 Jonathan Bedard 2019-07-08 12:23:46 PDT 
Comment on attachment 373643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373643&action=review

>> Tools/Scripts/webkitpy/test/main.py:107
>>      build_version = _host.platform.build_version()
> 
> Do we need this method (_supports_building_and_running_lldb_tests) at all after this change?
> 
> Seems like it was added in https://trac.webkit.org/changeset/246662/webkit

I'd like to keep it until the FIX-ME is resolved.

I think there is a non-zero chance we need to do this again (because of TCC prompts), and after r247139, this is also acting as a platform check for lldb tests, since they aren't supported on Linux at the moment.
Comment 6 WebKit Commit Bot 2019-07-08 12:57:33 PDT 
Comment on attachment 373643 [details]
Patch

Clearing flags on attachment: 373643

Committed r247228: <https://trac.webkit.org/changeset/247228>
Comment 7 WebKit Commit Bot 2019-07-08 12:57:35 PDT 
All reviewed patches have been landed.  Closing bug.