| Summary: | Unable to paste from Notes into Excel 365 spreadsheet | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||
| Component: | HTML Editing | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bdakin, cdumez, commit-queue, rniwa, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Wenson Hsieh
2019-07-07 17:04:14 PDT
Created attachment 373609 [details]
Patch
Created attachment 373610 [details]
Actually add the test
Created attachment 373624 [details]
Fix typo in ChangeLog.
Comment on attachment 373624 [details] Fix typo in ChangeLog. View in context: https://bugs.webkit.org/attachment.cgi?id=373624&action=review > Source/WebCore/page/Page.h:656 > + void setIsForSanitizingWebContent(bool isForSanitizingWebContent) { m_isForSanitizingWebContent = isForSanitizingWebContent; } Personally, I would omit the boolean parameter since this can never be set back to false after being set to true. Comment on attachment 373624 [details] Fix typo in ChangeLog. View in context: https://bugs.webkit.org/attachment.cgi?id=373624&action=review Thanks for the review! >> Source/WebCore/page/Page.h:656 >> + void setIsForSanitizingWebContent(bool isForSanitizingWebContent) { m_isForSanitizingWebContent = isForSanitizingWebContent; } > > Personally, I would omit the boolean parameter since this can never be set back to false after being set to true. Sounds good — will remove the bool param and make this just set m_isForSanitizingWebContent to true. Created attachment 373628 [details]
Patch for landing
Comment on attachment 373628 [details] Patch for landing Clearing flags on attachment: 373628 Committed r247222: <https://trac.webkit.org/changeset/247222> |