Bug 199565

Summary: Unable to paste from Notes into Excel 365 spreadsheet
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, commit-queue, rniwa, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Actually add the test
none
Fix typo in ChangeLog.
cdumez: review+
Patch for landing none

Wenson Hsieh
Reported 2019-07-07 17:04:14 PDT
<rdar://problem/43615497>
Attachments
Patch (7.11 KB, patch)
2019-07-07 17:36 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Actually add the test (10.73 KB, patch)
2019-07-07 17:50 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix typo in ChangeLog. (10.84 KB, patch)
2019-07-08 07:32 PDT, Wenson Hsieh 		cdumez: review+
DetailsFormatted DiffDiff
Patch for landing (10.78 KB, patch)
2019-07-08 08:50 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-07-07 17:36:20 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2019-07-07 17:50:14 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 3 2019-07-08 07:32:58 PDT
Created attachment 373624 [details] Fix typo in ChangeLog.
Chris Dumez
Comment 4 2019-07-08 08:35:40 PDT
Comment on attachment 373624 [details] Fix typo in ChangeLog. View in context: https://bugs.webkit.org/attachment.cgi?id=373624&action=review > Source/WebCore/page/Page.h:656 > + void setIsForSanitizingWebContent(bool isForSanitizingWebContent) { m_isForSanitizingWebContent = isForSanitizingWebContent; } Personally, I would omit the boolean parameter since this can never be set back to false after being set to true.
Wenson Hsieh
Comment 5 2019-07-08 08:37:13 PDT
Comment on attachment 373624 [details] Fix typo in ChangeLog. View in context: https://bugs.webkit.org/attachment.cgi?id=373624&action=review Thanks for the review! >> Source/WebCore/page/Page.h:656 >> + void setIsForSanitizingWebContent(bool isForSanitizingWebContent) { m_isForSanitizingWebContent = isForSanitizingWebContent; } > > Personally, I would omit the boolean parameter since this can never be set back to false after being set to true. Sounds good — will remove the bool param and make this just set m_isForSanitizingWebContent to true.
Wenson Hsieh
Comment 6 2019-07-08 08:50:39 PDT
Created attachment 373628 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-07-08 11:59:55 PDT
Comment on attachment 373628 [details] Patch for landing Clearing flags on attachment: 373628 Committed r247222: <https://trac.webkit.org/changeset/247222>
Note You need to log in before you can comment on or make changes to this bug.