Bug 199553

Summary: Web Inspector: the "x" in the Exception icon overlaps the border
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Devin Rousso
Reported 2019-07-06 12:11:05 PDT
.
Attachments
Patch (3.47 KB, patch)
2019-07-06 12:25 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (3.58 KB, patch)
2019-07-06 12:30 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (9.46 KB, patch)
2019-07-08 15:03 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-07-06 12:25:43 PDT
Created attachment 373570 [details] Patch
Devin Rousso
Comment 2 2019-07-06 12:30:23 PDT
Created attachment 373573 [details] Patch
Joseph Pecoraro
Comment 3 2019-07-08 14:41:07 PDT
Comment on attachment 373573 [details] Patch This was the case in Xcode before they changed their style, though seems like it was 1px and not 2px of overlap. I'm ambivalent. rs=me
Ross Kirsling
Comment 4 2019-07-08 14:46:24 PDT
Note that Function.svg and TailDeletedFunction.svg have the same issue on the bottom.
Devin Rousso
Comment 5 2019-07-08 14:50:19 PDT
(In reply to Ross Kirsling from comment #4) > Note that Function.svg and TailDeletedFunction.svg have the same issue on the bottom. (╯°□°）╯︵ ┻━┻
Devin Rousso
Comment 6 2019-07-08 15:03:57 PDT
Created attachment 373668 [details] Patch
WebKit Commit Bot
Comment 7 2019-07-08 17:03:59 PDT
Comment on attachment 373668 [details] Patch Clearing flags on attachment: 373668 Committed r247240: <https://trac.webkit.org/changeset/247240>
WebKit Commit Bot
Comment 8 2019-07-08 17:04:00 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-07-08 17:09:33 PDT
<rdar://problem/52805887>
Note You need to log in before you can comment on or make changes to this bug.