Bug 199553 - Web Inspector: the "x" in the Exception icon overlaps the border
Summary: Web Inspector: the "x" in the Exception icon overlaps the border
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-06 12:11 PDT by Devin Rousso
Modified: 2019-07-08 17:09 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.47 KB, patch)
2019-07-06 12:25 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (3.58 KB, patch)
2019-07-06 12:30 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (9.46 KB, patch)
2019-07-08 15:03 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-07-06 12:11:05 PDT 
.
Comment 1 Devin Rousso 2019-07-06 12:25:43 PDT 
Created attachment 373570 [details]
Patch
Comment 2 Devin Rousso 2019-07-06 12:30:23 PDT 
Created attachment 373573 [details]
Patch
Comment 3 Joseph Pecoraro 2019-07-08 14:41:07 PDT 
Comment on attachment 373573 [details]
Patch

This was the case in Xcode before they changed their style, though seems like it was 1px and not 2px of overlap. I'm ambivalent.

rs=me
Comment 4 Ross Kirsling 2019-07-08 14:46:24 PDT 
Note that Function.svg and TailDeletedFunction.svg have the same issue on the bottom.
Comment 5 Devin Rousso 2019-07-08 14:50:19 PDT 
(In reply to Ross Kirsling from comment #4)
> Note that Function.svg and TailDeletedFunction.svg have the same issue on the bottom.
(╯°□°）╯︵ ┻━┻
Comment 6 Devin Rousso 2019-07-08 15:03:57 PDT 
Created attachment 373668 [details]
Patch
Comment 7 WebKit Commit Bot 2019-07-08 17:03:59 PDT 
Comment on attachment 373668 [details]
Patch

Clearing flags on attachment: 373668

Committed r247240: <https://trac.webkit.org/changeset/247240>
Comment 8 WebKit Commit Bot 2019-07-08 17:04:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-07-08 17:09:33 PDT 
<rdar://problem/52805887>