Summary: | switch(String) needs to check for exceptions when resolving the string | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, saam, tzagallo, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Michael Saboff
2019-07-05 20:06:16 PDT
Created attachment 373560 [details]
Patch
Comment on attachment 373560 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373560&action=review r=me with throwScope declaration fix. > Source/JavaScriptCore/dfg/DFGOperations.cpp:2478 > nit: can you remove this empty line? > Source/JavaScriptCore/jit/JITOperations.cpp:2320 > + auto throwScope = DECLARE_THROW_SCOPE(vm); You should declare this at the top of the function at the earliest possible location. This is the recommended best practice unless there's a really good reason not to. (In reply to Mark Lam from comment #3) > Comment on attachment 373560 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373560&action=review > > r=me with throwScope declaration fix. > > > Source/JavaScriptCore/dfg/DFGOperations.cpp:2478 > > > > nit: can you remove this empty line? > > > Source/JavaScriptCore/jit/JITOperations.cpp:2320 > > + auto throwScope = DECLARE_THROW_SCOPE(vm); > > You should declare this at the top of the function at the earliest possible > location. This is the recommended best practice unless there's a really > good reason not to. I made these changes. Committed r247194: <https://trac.webkit.org/changeset/247194> |