| Summary: | [ATK] Do not use C linkage for functions using C++ features | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||
| Component: | Accessibility | Assignee: | Adrian Perez <aperez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, cgarcia, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 373485 [details]
Patch
Comment on attachment 373485 [details] Patch Clearing flags on attachment: 373485 Committed r247149: <https://trac.webkit.org/changeset/247149> All reviewed patches have been landed. Closing bug. |
Clang correctly warns about the following: In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-f34946be-9.cpp:1: In file included from ../Source/WebCore/editing/atk/FrameSelectionAtk.cpp:29: ../Source/WebCore/accessibility/atk/WebKitAccessible.h:74:31: warning: 'webkitAccessibleGetAccessibilityObject' has C-linkage specified, but returns user-defined type 'WebCore::AccessibilityObject &' which is incompatible with C [-Wreturn-type-c-linkage] WebCore::AccessibilityObject& webkitAccessibleGetAccessibilityObject(WebKitAccessible*); ^