Bug 199498

Summary: Scribble Heap::m_worldState on destructor
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: JavaScriptCoreAssignee: Tadeu Zagallo <tzagallo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, rmorisset, saam, sam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Tadeu Zagallo
Reported 2019-07-04 07:46:20 PDT
...
Attachments
Patch (1.27 KB, patch)
2019-07-04 07:49 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.37 KB, patch)
2019-07-05 01:10 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2019-07-04 07:49:50 PDT
Created attachment 373465 [details] Patch
Sam Weinig
Comment 2 2019-07-04 15:24:32 PDT
Comment on attachment 373465 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373465&action=review > Source/JavaScriptCore/heap/Heap.cpp:342 > + m_worldState.store(0xbadbeef0u); I think a comment here clarifying why this store is being made would be instructive.
Tadeu Zagallo
Comment 3 2019-07-05 01:08:01 PDT
Comment on attachment 373465 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373465&action=review Thanks for the review! >> Source/JavaScriptCore/heap/Heap.cpp:342 >> + m_worldState.store(0xbadbeef0u); > > I think a comment here clarifying why this store is being made would be instructive. That makes sense, I'll add it.
Tadeu Zagallo
Comment 4 2019-07-05 01:10:22 PDT
Created attachment 373483 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-07-05 09:38:47 PDT
Comment on attachment 373483 [details] Patch for landing Clearing flags on attachment: 373483 Committed r247160: <https://trac.webkit.org/changeset/247160>
WebKit Commit Bot
Comment 6 2019-07-05 09:38:48 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-07-05 09:39:15 PDT
<rdar://problem/52690607>
Tadeu Zagallo
Comment 8 2019-07-05 11:37:40 PDT
I just realized this value won't work... it will clear the conn bit. I'll land a follow-up patch to change it to 0xbadbeeff.
Tadeu Zagallo
Comment 9 2019-07-05 11:58:07 PDT
Committed r247166: <https://trac.webkit.org/changeset/247166>
Note You need to log in before you can comment on or make changes to this bug.