| Summary: | Scribble Heap::m_worldState on destructor | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tadeu Zagallo <tzagallo> | ||||||
| Component: | JavaScriptCore | Assignee: | Tadeu Zagallo <tzagallo> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, rmorisset, saam, sam, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tadeu Zagallo
2019-07-04 07:46:20 PDT
Created attachment 373465 [details]
Patch
Comment on attachment 373465 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373465&action=review > Source/JavaScriptCore/heap/Heap.cpp:342 > + m_worldState.store(0xbadbeef0u); I think a comment here clarifying why this store is being made would be instructive. Comment on attachment 373465 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373465&action=review Thanks for the review! >> Source/JavaScriptCore/heap/Heap.cpp:342 >> + m_worldState.store(0xbadbeef0u); > > I think a comment here clarifying why this store is being made would be instructive. That makes sense, I'll add it. Created attachment 373483 [details]
Patch for landing
Comment on attachment 373483 [details] Patch for landing Clearing flags on attachment: 373483 Committed r247160: <https://trac.webkit.org/changeset/247160> All reviewed patches have been landed. Closing bug. I just realized this value won't work... it will clear the conn bit. I'll land a follow-up patch to change it to 0xbadbeeff. Committed r247166: <https://trac.webkit.org/changeset/247166> |