Bug 199490

Summary: Touching media controls sometimes shows software keyboard
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: HTML EditingAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Eric Carlson 2019-07-03 19:55:40 PDT 
Touching media controls immediately after page load sometimes shows software keyboard.
Comment 1 Eric Carlson 2019-07-03 19:55:52 PDT 
<rdar://problem/52076270>
Comment 2 Eric Carlson 2019-07-03 19:59:49 PDT 
Created attachment 373450 [details]
Patch
Comment 3 Wenson Hsieh 2019-07-04 14:12:00 PDT 
Comment on attachment 373450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373450&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2899
> +        if (oldFocusedElement == newFocusedElement && newFocusedElement->isContentEditable())

I got a chance to debug this a bit — a few observations…

1. newFocusedElement in this case is <INPUT id='' type='text' class='active’> when tapping on the media controls.
2. It looks like this change would make the bug go away by preventing the <INPUT id='' type='text' class='active’> from being refocused. This is because the input element itself is not content editable, but rather, is a text form control (which contains an editable area).
Comment 4 Wenson Hsieh 2019-07-04 15:41:55 PDT 
Created attachment 373473 [details]
Patch
Comment 5 Eric Carlson 2019-07-05 08:48:13 PDT 
Thanks Wenson!
Comment 6 WebKit Commit Bot 2019-07-05 09:22:49 PDT 
Comment on attachment 373473 [details]
Patch

Clearing flags on attachment: 373473

Committed r247158: <https://trac.webkit.org/changeset/247158>
Comment 7 WebKit Commit Bot 2019-07-05 09:22:50 PDT 
All reviewed patches have been landed.  Closing bug.