Bug 199483

Summary: Test freshness page should expose revision information for latest build on tooltip.
Product: WebKit Reporter: dewei_zhu
Component: New BugsAssignee: dewei_zhu
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch rniwa: review+

dewei_zhu
Reported 2019-07-03 17:11:57 PDT
Test freshness page should expose revision information for latest build on tooltip.
Attachments
Patch (10.45 KB, patch)
2019-07-03 17:14 PDT, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Patch (10.52 KB, patch)
2019-07-03 17:27 PDT, dewei_zhu 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2019-07-03 17:14:27 PDT
Created attachment 373440 [details] Patch
dewei_zhu
Comment 2 2019-07-03 17:27:47 PDT
Created attachment 373442 [details] Patch
Ryosuke Niwa
Comment 3 2019-07-04 01:55:16 PDT
Comment on attachment 373442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373442&action=review > Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js:94 > + let commitSet = null; commitSetOfLastPoint? > Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js:178 > + for (const repository of Repository.sortByNamePreferringOnesWithURL(commitSet.repositories())) { > + const commit = commitSet.commitForRepository(repository); > + tableContent.push(element('tr', [ Better written as: tableContent.push(Repository.sortByNamePreferringOnesWithURL(commitSet.repositories()).map((repository) => { ~ }); Note: CommonComponentBase._addContentToElement would unwrap nested arrays.
dewei_zhu
Comment 4 2019-07-08 11:52:51 PDT
Landed in r247168.
Note You need to log in before you can comment on or make changes to this bug.