| Summary: | Test freshness page should expose revision information for latest build on tooltip. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | dewei_zhu | ||||||
| Component: | New Bugs | Assignee: | dewei_zhu | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dewei_zhu, rniwa | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
dewei_zhu
2019-07-03 17:11:57 PDT
Created attachment 373440 [details]
Patch
Created attachment 373442 [details]
Patch
Comment on attachment 373442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373442&action=review > Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js:94 > + let commitSet = null; commitSetOfLastPoint? > Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js:178 > + for (const repository of Repository.sortByNamePreferringOnesWithURL(commitSet.repositories())) { > + const commit = commitSet.commitForRepository(repository); > + tableContent.push(element('tr', [ Better written as: tableContent.push(Repository.sortByNamePreferringOnesWithURL(commitSet.repositories()).map((repository) => { ~ }); Note: CommonComponentBase._addContentToElement would unwrap nested arrays. |