Summary: | [iOS 13] Enable WebKit build | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||||||||
Component: | Platform | Assignee: | Jonathan Bedard <jbedard> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | ajuma, ap, commit-queue, ews-watchlist, fred.wang, simon.fraser, thorton, timothy, webkit-bug-importer, wenson_hsieh | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=199209 | ||||||||||||||||
Attachments: |
|
Description
Jonathan Bedard
2019-07-03 16:45:44 PDT
Created attachment 373752 [details]
patch-1
Attachment 373752 [details] did not pass style-queue:
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSProgressSPI.h:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
Total errors found: 1 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 373756 [details]
patch-2
Attachment 373756 [details] did not pass style-queue:
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSProgressSPI.h:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
Total errors found: 1 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 373787 [details]
patch-3
Attachment 373787 [details] did not pass style-queue:
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSProgressSPI.h:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
Total errors found: 1 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 373791 [details]
patch-4
Attachment 373791 [details] did not pass style-queue:
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSProgressSPI.h:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
Total errors found: 1 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
This bug needs a better title. Created attachment 373879 [details]
patch-5
Attachment 373879 [details] did not pass style-queue:
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSProgressSPI.h:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5]
Total errors found: 1 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 373879 [details] patch-5 Clearing flags on attachment: 373879 Committed r247355: <https://trac.webkit.org/changeset/247355> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 379002 [details]
Patch
Comment on attachment 379002 [details] Patch Clearing flags on attachment: 379002 Committed r250020: <https://trac.webkit.org/changeset/250020> All reviewed patches have been landed. Closing bug. |