Bug 199468

Summary: Clarify threading model for WebResourceLoadStatisticsStore::dumpResourceLoadStatistics()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, sihui_liu, webkit-bug-importer, wilander, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=196307
Bug Depends on:    
Bug Blocks: 196307    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2019-07-03 15:25:57 PDT 
Clarify threading model for WebResourceLoadStatisticsStore::dumpResourceLoadStatistics() after r245517.
Comment 1 Chris Dumez 2019-07-03 15:29:45 PDT 
Created attachment 373422 [details]
Patch
Comment 2 youenn fablet 2019-07-03 16:38:45 PDT 
Comment on attachment 373422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373422&action=review

> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:76
> +    void dumpResourceLoadStatistics(CompletionHandler<void(const String&)>&&) override;

final

> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:82
> +    void dumpResourceLoadStatistics(CompletionHandler<void(const String&)>&&) override;

final
Comment 3 Chris Dumez 2019-07-03 16:41:09 PDT 
Created attachment 373434 [details]
Patch
Comment 4 WebKit Commit Bot 2019-07-03 17:23:32 PDT 
Comment on attachment 373434 [details]
Patch

Clearing flags on attachment: 373434

Committed r247119: <https://trac.webkit.org/changeset/247119>
Comment 5 WebKit Commit Bot 2019-07-03 17:23:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-07-03 17:24:15 PDT 
<rdar://problem/52620712>