Bug 199465

Summary: REGRESSION (r246817): fast/events/ios/key-events-comprehensive/key-events-{control, control-shift}.html are failing
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar, PlatformOnly, Regression
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: Unspecified   
Bug Depends on: 199204    
Bug Blocks:    
Description Flags
Patch none

Description Daniel Bates 2019-07-03 15:03:21 PDT
Oops! In the fix for bug #199204 I was a bit too nice. It does not make sense to allow cursor key commands when there is no selection. The tests:

fast/events/ios/key-events-comprehensive/key-events-{control, control-shift}.html are failing

fail because try to perform cursor movements (like Control + A to move to the start of the line) even when there is no selection. Handled key commands don't dispatch DOM keypress events.
Comment 1 Radar WebKit Bug Importer 2019-07-03 15:03:36 PDT
Comment 2 Daniel Bates 2019-07-03 15:05:59 PDT
Created attachment 373417 [details]
Comment 3 Daniel Bates 2019-07-03 16:22:49 PDT
Comment on attachment 373417 [details]

Clearing flags on attachment: 373417

Committed r247116: <https://trac.webkit.org/changeset/247116>
Comment 4 Daniel Bates 2019-07-03 16:22:50 PDT
All reviewed patches have been landed.  Closing bug.