Bug 199461

Summary: Isolate CacheStorage::Engine path when hopping to a background thread
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2019-07-03 13:47:04 PDT 
Isolate CacheStorage::Engine path when hopping to a background thread
Comment 1 youenn fablet 2019-07-03 13:56:14 PDT 
Created attachment 373414 [details]
Patch
Comment 2 Chris Dumez 2019-07-03 14:02:56 PDT 
Comment on attachment 373414 [details]
Patch

is the usage on m_rootPath inside Engine::fetchEntries() correct?
Comment 3 youenn fablet 2019-07-03 14:50:22 PDT 
(In reply to Chris Dumez from comment #2)
> Comment on attachment 373414 [details]
> Patch
> 
> is the usage on m_rootPath inside Engine::fetchEntries() correct?

Yes, it is fine.
But we should really move the code listing the files of a directory to a background thread.
Comment 4 WebKit Commit Bot 2019-07-03 15:14:10 PDT 
Comment on attachment 373414 [details]
Patch

Clearing flags on attachment: 373414

Committed r247111: <https://trac.webkit.org/changeset/247111>
Comment 5 WebKit Commit Bot 2019-07-03 15:14:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-07-03 15:15:17 PDT 
<rdar://problem/52614234>