Bug 199456

Summary:

Use smarter pointers in WKDownloadProgress

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Alex Christensen 2019-07-03 10:15:07 PDT

Use smarter pointers in WKDownloadProgress

Comment 1 Alex Christensen 2019-07-03 10:17:31 PDT

Created attachment 373397 [details]
Patch

Comment 2 Alex Christensen 2019-07-03 10:17:33 PDT

<rdar://problem/51392926>

Comment 3 Chris Dumez 2019-07-03 13:14:49 PDT

Comment on attachment 373397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373397&action=review

> Source/WebKit/NetworkProcess/Downloads/cocoa/WKDownloadProgress.mm:76
> +        if (!isMainThread()) {

!RunLoop::isMain() to avoid issues when the app uses both WK1 and WK2.

Comment 4 Alex Christensen 2019-07-03 13:17:58 PDT

Created attachment 373408 [details]
Patch

Comment 5 WebKit Commit Bot 2019-07-03 14:01:57 PDT

Comment on attachment 373408 [details]
Patch

Clearing flags on attachment: 373408

Committed r247103: <https://trac.webkit.org/changeset/247103>

Comment 6 WebKit Commit Bot 2019-07-03 14:01:58 PDT

All reviewed patches have been landed.  Closing bug.