Bug 199456 - Use smarter pointers in WKDownloadProgress
Summary: Use smarter pointers in WKDownloadProgress
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-03 10:15 PDT by Alex Christensen
Modified: 2019-07-03 14:01 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.66 KB, patch)
2019-07-03 10:17 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (6.66 KB, patch)
2019-07-03 13:17 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-07-03 10:15:07 PDT
Use smarter pointers in WKDownloadProgress
Comment 1 Alex Christensen 2019-07-03 10:17:31 PDT
Created attachment 373397 [details]
Patch
Comment 2 Alex Christensen 2019-07-03 10:17:33 PDT
<rdar://problem/51392926>
Comment 3 Chris Dumez 2019-07-03 13:14:49 PDT
Comment on attachment 373397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373397&action=review

> Source/WebKit/NetworkProcess/Downloads/cocoa/WKDownloadProgress.mm:76
> +        if (!isMainThread()) {

!RunLoop::isMain() to avoid issues when the app uses both WK1 and WK2.
Comment 4 Alex Christensen 2019-07-03 13:17:58 PDT
Created attachment 373408 [details]
Patch
Comment 5 WebKit Commit Bot 2019-07-03 14:01:57 PDT
Comment on attachment 373408 [details]
Patch

Clearing flags on attachment: 373408

Committed r247103: <https://trac.webkit.org/changeset/247103>
Comment 6 WebKit Commit Bot 2019-07-03 14:01:58 PDT
All reviewed patches have been landed.  Closing bug.