Summary: | REGRESSION (r243240): Unable to swipe back in Safari | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | beidson, cdumez, commit-queue, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2019-07-01 20:08:01 PDT
Created attachment 373302 [details]
Patch
Comment on attachment 373302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373302&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-1900 > - _gestureController = nullptr; So we do not even need a call to _gestureController->disconnectFromProcess() ? (In reply to Chris Dumez from comment #3) > Comment on attachment 373302 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373302&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-1900 > > - _gestureController = nullptr; > > So we do not even need a call to _gestureController->disconnectFromProcess() > ? Hmm, I don't think so? The connect just bails and all is well (and they communicate by pageID so things just fall back into place. I'll check if it's safe to disconnect and if it is we'll do that just for safety/readability's sake, though. Created attachment 373356 [details]
Patch
Comment on attachment 373356 [details]
Patch
LGTM too.
Comment on attachment 373356 [details] Patch Clearing flags on attachment: 373356 Committed r247073: <https://trac.webkit.org/changeset/247073> All reviewed patches have been landed. Closing bug. |