Bug 199394

Summary: REGRESSION (r243240): Unable to swipe back in Safari
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Tim Horton 2019-07-01 20:08:01 PDT
REGRESSION (r243240): Unable to swipe back in Safari
Comment 1 Tim Horton 2019-07-01 20:08:09 PDT
Created attachment 373302 [details]
Patch
Comment 2 Tim Horton 2019-07-01 20:08:10 PDT
<rdar://problem/51137447>
Comment 3 Chris Dumez 2019-07-01 20:19:31 PDT
Comment on attachment 373302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373302&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-1900
> -    _gestureController = nullptr;

So we do not even need a call to _gestureController->disconnectFromProcess() ?
Comment 4 Tim Horton 2019-07-01 22:08:12 PDT
(In reply to Chris Dumez from comment #3)
> Comment on attachment 373302 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373302&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-1900
> > -    _gestureController = nullptr;
> 
> So we do not even need a call to _gestureController->disconnectFromProcess()
> ?

Hmm, I don't think so? The connect just bails and all is well (and they communicate by pageID so things just fall back into place. I'll check if it's safe to disconnect and if it is we'll do that just for safety/readability's sake, though.
Comment 5 Tim Horton 2019-07-02 13:43:17 PDT
Created attachment 373356 [details]
Patch
Comment 6 Chris Dumez 2019-07-02 14:19:39 PDT
Comment on attachment 373356 [details]
Patch

LGTM too.
Comment 7 WebKit Commit Bot 2019-07-02 15:04:16 PDT
Comment on attachment 373356 [details]
Patch

Clearing flags on attachment: 373356

Committed r247073: <https://trac.webkit.org/changeset/247073>
Comment 8 WebKit Commit Bot 2019-07-02 15:04:18 PDT
All reviewed patches have been landed.  Closing bug.