Bug 199393

Summary:

Command + . generates Escape with key identifier Period, should be Escape

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebKit Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar, PlatformOnly

Version:

WebKit Nightly Build

Hardware:

iPhone / iPad

OS:

Unspecified

URL:

https://w3c.github.io/uievents/tools/key-event-viewer.html

See Also:

https://bugs.webkit.org/show_bug.cgi?id=198137

Bug Depends on:

Bug Blocks:

190571

Attachments:

Description	Flags
Patch	none
Patch	none

Daniel Bates

Reported 2019-07-01 19:25:43 PDT

Steps to reproduce: 1. Visit <https://w3c.github.io/uievents/tools/key-event-viewer.html> 2. Focus the text field 3. Press Command + . Then you see a key down and key press with key Escape, but code Period 😃. (Also keyup is missing, but that’s “expected” because it was generated from a key command. I put “expected” in quotes, because I’m kinda leaning towards fixing that in UIKit just for Escape).

Attachments
Patch (5.30 KB, patch) 2019-07-05 11:01 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (5.46 KB, patch) 2019-07-05 11:02 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-07-01 19:25:51 PDT

<rdar://problem/52498001>

Daniel Bates

Comment 2 2019-07-05 10:56:50 PDT

There's a few ways I could go about with this bug: 1. Do what I originally complained about: fix the key code of the dispatched event to be Escape instead of Period. 2. Take this opportunity to re-evaluate this whole Command + . business: maybe the experience should match the experience when typing a Roman variant (e.g. Option + 2 == ™) => this dispatches (looking at key codes): keydown Option, keydown 2, keypress ™, keyup 2, keyup Option. The benefit of (2) is that a web app could still know about Command + . and have their own handling. But how many web apps would even care about this? I know of 0 web apps that have their own Command + . handling and it's such an esoteric Mac/iOS key command that I kinda doubt a web app would unless that app is targeted at such platforms or embedded in a native app on those platforms. Another downside is that it reveals an implementation detail and we don't reveal such a detail to native apps on iOS..... Lastly, if we do (1) and a developer really wants to distinguish between Escape and Command + . they still can! They just have to do a little bit more work and track keydown, keyup Command whenever they see a keydown/keypress of Escape. So, I'm leaning towards doing (1).

Daniel Bates

Comment 3 2019-07-05 11:01:30 PDT

Created attachment 373515 [details] Patch

Daniel Bates

Comment 4 2019-07-05 11:02:53 PDT

Created attachment 373516 [details] Patch

Daniel Bates

Comment 5 2019-07-08 16:07:07 PDT

Comment on attachment 373516 [details] Patch Clearing flags on attachment: 373516 Committed r247232: <https://trac.webkit.org/changeset/247232>

Daniel Bates

Comment 6 2019-07-08 16:07:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.