Bug 199345

Summary:

Pass WebProcess information to platformInitializeWebProcess().

Product:

WebKit

Reporter:

Basuke Suzuki <basuke>

Component:

WebKit2

Assignee:

Basuke Suzuki <basuke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, basuke, commit-queue, darin, mcatanzaro, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
PATCH	none
Try again	darin: review+
PATCH	none

Basuke Suzuki

Reported 2019-06-29 20:11:40 PDT

Some initialization requires web process information. Currently no information is available when platformInitializeWebProcess() is called.

Attachments
PATCH (5.19 KB, patch) 2019-06-29 20:16 PDT, Basuke Suzuki	no flags	Details Formatted Diff Diff
Try again (5.09 KB, patch) 2019-06-29 21:05 PDT, Basuke Suzuki	darin: review+	Details Formatted Diff Diff
PATCH (6.21 KB, patch) 2019-06-30 13:25 PDT, Basuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Basuke Suzuki

Comment 1 2019-06-29 20:16:44 PDT

Created attachment 373182 [details] PATCH

Basuke Suzuki

Comment 2 2019-06-29 20:21:12 PDT

On WinCairo, we will need to pass socket identifier from UIProcess to WebProcess for RemoteInspector Server. On Windows, we need an id of destination process to copy the socket information. https://docs.microsoft.com/en-us/windows/desktop/api/winsock2/nf-winsock2-wsaduplicatesocketa We figured out current WebProcessPool has WebProcess information via WebProcessProxy while initializing WebProcessCreationParameters, but that info was not passed to platformInitializeWebProcess(). We can achieve our purpose by PLATFORM patch on WebProcessPool.cpp, but having such code in platform dependent file is better.

Basuke Suzuki

Comment 3 2019-06-29 21:05:53 PDT

Created attachment 373184 [details] Try again

Darin Adler

Comment 4 2019-06-30 12:50:18 PDT

Comment on attachment 373184 [details] Try again r=me

Basuke Suzuki

Comment 5 2019-06-30 13:25:45 PDT

Created attachment 373196 [details] PATCH

Basuke Suzuki

Comment 6 2019-06-30 14:28:50 PDT

Thanks! (In reply to Darin Adler from comment #4) > Comment on attachment 373184 [details] > Try again > > r=me Thanks!