Bug 199344

Summary: RenderObject::absoluteClippedOverflowRect() should not be affected by whether composited scrolling is enabled
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED INVALID    
Severity: Normal CC: clord, ews-watchlist, rniwa, simon.fraser, thorton, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226007
Attachments:
Description Flags
Patch, needs tests
none
Patch
none
Archive of layout-test-results from ews103 for mac-highsierra
none
Archive of layout-test-results from ews106 for mac-highsierra-wk2
none
Archive of layout-test-results from ews113 for mac-highsierra
none
Patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews100 for mac-highsierra
none
Archive of layout-test-results from ews106 for mac-highsierra-wk2
none
Archive of layout-test-results from ews113 for mac-highsierra
none
patch none

Description Simon Fraser (smfr) 2019-06-29 16:23:38 PDT
RenderObject::absoluteClippedOverflowRect() should not be affected by whether composited scrolling is enabled
Comment 1 Simon Fraser (smfr) 2019-06-29 16:32:54 PDT
Created attachment 373179 [details]
Patch, needs tests
Comment 2 EWS Watchlist 2019-06-29 16:46:14 PDT Comment hidden (obsolete)
Comment 3 Tim Horton 2019-07-01 15:10:08 PDT
Created attachment 373273 [details]
Patch
Comment 4 Tim Horton 2019-07-01 15:11:03 PDT Comment hidden (obsolete)
Comment 5 EWS Watchlist 2019-07-01 16:02:29 PDT Comment hidden (obsolete)
Comment 6 EWS Watchlist 2019-07-01 16:02:31 PDT Comment hidden (obsolete)
Comment 7 EWS Watchlist 2019-07-01 16:31:05 PDT Comment hidden (obsolete)
Comment 8 EWS Watchlist 2019-07-01 16:31:07 PDT Comment hidden (obsolete)
Comment 9 EWS Watchlist 2019-07-01 17:09:57 PDT Comment hidden (obsolete)
Comment 10 EWS Watchlist 2019-07-01 17:09:58 PDT Comment hidden (obsolete)
Comment 11 Tim Horton 2019-07-01 17:11:09 PDT
Created attachment 373283 [details]
Patch
Comment 12 EWS Watchlist 2019-07-01 18:24:17 PDT
Comment on attachment 373283 [details]
Patch

Attachment 373283 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12633597

New failing tests:
fast/text/mark-matches-overflow-clip-async-scrolling.html
Comment 13 EWS Watchlist 2019-07-01 18:24:19 PDT
Created attachment 373295 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 14 EWS Watchlist 2019-07-01 18:33:02 PDT
Comment on attachment 373283 [details]
Patch

Attachment 373283 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12633620

New failing tests:
fast/text/mark-matches-overflow-clip-async-scrolling.html
Comment 15 EWS Watchlist 2019-07-01 18:33:04 PDT
Created attachment 373297 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 16 EWS Watchlist 2019-07-01 18:46:09 PDT
Comment on attachment 373283 [details]
Patch

Attachment 373283 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12633503

New failing tests:
fast/text/mark-matches-overflow-clip-async-scrolling.html
Comment 17 EWS Watchlist 2019-07-01 18:46:11 PDT
Created attachment 373298 [details]
Archive of layout-test-results from ews113 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 18 Tim Horton 2019-07-01 18:57:24 PDT
I'm a dummy and uploaded the before result as the expected :|
Comment 19 Tim Horton 2019-07-01 18:58:52 PDT
Created attachment 373299 [details]
patch
Comment 20 Simon Fraser (smfr) 2019-07-03 21:12:26 PDT
Did this land?
Comment 21 Tim Horton 2019-07-03 22:41:06 PDT
Don’t think so, was fighting EWS.
Comment 22 Chris Lord 2021-05-21 04:05:33 PDT
absoluteClippedOverflowRect has now been replaced by absoluteClippedOverflowRectForRepaint (which is affected by composited scrolling) and absoluteClippedOverflowRectForSpatialNavigation (which isn't).