Bug 199337

Summary: unable to build WebRTC for iOS Simulator
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Description Dean Jackson 2019-06-28 13:47:01 PDT 
unable to build WebRTC for iOS Simulator
Comment 1 Dean Jackson 2019-06-28 13:47:36 PDT 
<rdar://problem/52020841>
Comment 2 Dean Jackson 2019-06-28 13:50:30 PDT 
Created attachment 373147 [details]
Patch
Comment 3 Dean Jackson 2019-06-28 15:20:28 PDT 
Created attachment 373154 [details]
Patch
Comment 4 Tim Horton 2019-06-28 15:29:25 PDT 
Comment on attachment 373154 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373154&action=review

> Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:3384
> +			script = "DYLD_ROOT_PATH=/ ${BUILT_PRODUCTS_DIR}/yasm -fmacho64 -I ${SRCROOT}/Source/third_party/libvpx/source/config -I ${SRCROOT}/Source/third_party/libvpx/source/config/mac/x64 -I ${SRCROOT}/Source/third_party/libvpx/source/libvpx -o ${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o ${INPUT_FILE_DIR}/${INPUT_FILE_BASE}.asm\n";

This is /such a hack/ and needs a comment and a bug tracking properly building this for the host.
Comment 5 Dean Jackson 2019-06-28 15:42:37 PDT 
(In reply to Tim Horton from comment #4)
> Comment on attachment 373154 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373154&action=review
> 
> > Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:3384
> > +			script = "DYLD_ROOT_PATH=/ ${BUILT_PRODUCTS_DIR}/yasm -fmacho64 -I ${SRCROOT}/Source/third_party/libvpx/source/config -I ${SRCROOT}/Source/third_party/libvpx/source/config/mac/x64 -I ${SRCROOT}/Source/third_party/libvpx/source/libvpx -o ${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o ${INPUT_FILE_DIR}/${INPUT_FILE_BASE}.asm\n";
> 
> This is /such a hack/ and needs a comment and a bug tracking properly
> building this for the host.

I don't know where to put the comment. I could put it in the script field within the Xcode project, but no one will see that if they are looking at the build output.
Comment 6 Dean Jackson 2019-06-28 15:50:56 PDT 
Committed r246945: <https://trac.webkit.org/changeset/246945>