RESOLVED FIXED199337
unable to build WebRTC for iOS Simulator 
https://bugs.webkit.org/show_bug.cgi?id=199337
Summary unable to build WebRTC for iOS Simulator
Dean Jackson
Reported 2019-06-28 13:47:01 PDT
unable to build WebRTC for iOS Simulator
Attachments
Patch (1.43 KB, patch)
2019-06-28 13:50 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (2.16 KB, patch)
2019-06-28 15:20 PDT, Dean Jackson 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2019-06-28 13:47:36 PDT
<rdar://problem/52020841>
Dean Jackson
Comment 2 2019-06-28 13:50:30 PDT
Created attachment 373147 [details] Patch
Dean Jackson
Comment 3 2019-06-28 15:20:28 PDT
Created attachment 373154 [details] Patch
Tim Horton
Comment 4 2019-06-28 15:29:25 PDT
Comment on attachment 373154 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373154&action=review > Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:3384 > + script = "DYLD_ROOT_PATH=/ ${BUILT_PRODUCTS_DIR}/yasm -fmacho64 -I ${SRCROOT}/Source/third_party/libvpx/source/config -I ${SRCROOT}/Source/third_party/libvpx/source/config/mac/x64 -I ${SRCROOT}/Source/third_party/libvpx/source/libvpx -o ${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o ${INPUT_FILE_DIR}/${INPUT_FILE_BASE}.asm\n"; This is /such a hack/ and needs a comment and a bug tracking properly building this for the host.
Dean Jackson
Comment 5 2019-06-28 15:42:37 PDT
(In reply to Tim Horton from comment #4) > Comment on attachment 373154 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373154&action=review > > > Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:3384 > > + script = "DYLD_ROOT_PATH=/ ${BUILT_PRODUCTS_DIR}/yasm -fmacho64 -I ${SRCROOT}/Source/third_party/libvpx/source/config -I ${SRCROOT}/Source/third_party/libvpx/source/config/mac/x64 -I ${SRCROOT}/Source/third_party/libvpx/source/libvpx -o ${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o ${INPUT_FILE_DIR}/${INPUT_FILE_BASE}.asm\n"; > > This is /such a hack/ and needs a comment and a bug tracking properly > building this for the host. I don't know where to put the comment. I could put it in the script field within the Xcode project, but no one will see that if they are looking at the build output.
Dean Jackson
Comment 6 2019-06-28 15:50:56 PDT
Committed r246945: <https://trac.webkit.org/changeset/246945>
Note You need to log in before you can comment on or make changes to this bug.