| Summary: | Make ScrollbarControlSize an enum class | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, koivisto, kondapallykalyan, pdr, rbuis, sam, simon.fraser, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Simon Fraser (smfr)
2019-06-28 10:32:47 PDT
Created attachment 373129 [details]
Patch
Attachment 373129 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/mac/ScrollbarThemeMac.mm:301: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 373129 [details]
Patch
rs=me, but please get it building first.
Created attachment 404466 [details]
Patch
Created attachment 404548 [details]
Patch
Created attachment 404554 [details]
Patch
Created attachment 404555 [details]
Patch
Simon, it looks like this works after rebasing, so if you still want it feel free to commit. Committed r264525: <https://trac.webkit.org/changeset/264525> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404555 [details]. |