Bug 199325

Summary: Make ScrollbarControlSize an enum class
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, koivisto, kondapallykalyan, pdr, rbuis, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2019-06-28 10:32:47 PDT
Make ScrollbarControlSize an enum class
Attachments
Patch (23.11 KB, patch)
2019-06-28 10:33 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (23.83 KB, patch)
2020-07-16 11:07 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (25.35 KB, patch)
2020-07-17 01:02 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (26.86 KB, patch)
2020-07-17 03:57 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (26.86 KB, patch)
2020-07-17 04:23 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-06-28 10:33:33 PDT
Created attachment 373129 [details] Patch
EWS Watchlist
Comment 2 2019-06-28 10:36:01 PDT
Attachment 373129 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mac/ScrollbarThemeMac.mm:301: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2019-07-05 12:59:37 PDT
Comment on attachment 373129 [details] Patch rs=me, but please get it building first.
Rob Buis
Comment 4 2020-07-16 11:07:06 PDT
Created attachment 404466 [details] Patch
Rob Buis
Comment 5 2020-07-17 01:02:26 PDT
Created attachment 404548 [details] Patch
Rob Buis
Comment 6 2020-07-17 03:57:45 PDT
Created attachment 404554 [details] Patch
Rob Buis
Comment 7 2020-07-17 04:23:54 PDT
Created attachment 404555 [details] Patch
Rob Buis
Comment 8 2020-07-17 10:22:52 PDT
Simon, it looks like this works after rebasing, so if you still want it feel free to commit.
EWS
Comment 9 2020-07-17 11:38:09 PDT
Committed r264525: <https://trac.webkit.org/changeset/264525> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404555 [details].
Radar WebKit Bug Importer
Comment 10 2020-07-17 11:39:18 PDT
<rdar://problem/65736048>
Note You need to log in before you can comment on or make changes to this bug.